Skip to content

Conversation

@msaroufim
Copy link
Member

@msaroufim msaroufim commented Sep 27, 2025

Increased the default timeout from 300 to 600 seconds.

The right fix is probably this gpu-mode/reference-kernels#66 but we'd rather not change the eval right before the bioml competition concludes

We're doing this because a user reported for the bioml problem getting this error even though the timeouts there are set to 540s

Not sure it's a good idea to merge this though so i could be convinced either way

image

Increased the default timeout from 300 to 600 seconds.
Copilot AI review requested due to automatic review settings September 27, 2025 01:32
@github-actions
Copy link

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR increases the default timeout value for the modal_run_config function from 300 seconds (5 minutes) to 600 seconds (10 minutes) to allow for longer-running modal operations.

  • Updated default timeout parameter in modal_run_config function

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@msaroufim msaroufim merged commit 8c6f7a9 into main Sep 27, 2025
6 checks passed
@msaroufim msaroufim deleted the msaroufim-patch-9 branch September 27, 2025 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants