From 372fa40eead133bcc94cfb56bd6427366f62b268 Mon Sep 17 00:00:00 2001 From: Anthonios Partheniou Date: Fri, 6 May 2022 15:35:34 +0000 Subject: [PATCH 1/2] chore: fix boolean comparison --- scripts/buildprbody.py | 2 +- scripts/changesummary.py | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/buildprbody.py b/scripts/buildprbody.py index d70f23b6de1..b3881156498 100644 --- a/scripts/buildprbody.py +++ b/scripts/buildprbody.py @@ -80,7 +80,7 @@ def generate_pr_body(self): prestable_and_breaking = ( dataframe[ - (dataframe["IsStable"] == False) + (not dataframe["IsStable"]) & (dataframe["ChangeType"] == ChangeType.DELETED) ][["Name", "Version", "Commit"]] .drop_duplicates() diff --git a/scripts/changesummary.py b/scripts/changesummary.py index 2742b00b2e2..01e9bf8afe3 100644 --- a/scripts/changesummary.py +++ b/scripts/changesummary.py @@ -208,7 +208,7 @@ def _get_discovery_differences(self, filename): all_added = ( parent_added_agg[ (parent_added_agg["Proportion"] == 1) - & (parent_added_agg["Added"] == True) + & parent_added_agg["Added"] ][["Parent", "NumLevels"]] .sort_values("NumLevels", ascending=True) .Parent.to_list() @@ -220,7 +220,7 @@ def _get_discovery_differences(self, filename): all_deleted = ( parent_deleted_agg[ (parent_deleted_agg["Proportion"] == 1) - & (parent_deleted_agg["Deleted"] == True) + & parent_deleted_agg["Deleted"] ][["Parent", "NumLevels"]] .sort_values("NumLevels", ascending=True) .Parent.to_list() From f4ede19c4d9d97885712db52cc693fd50a1862fd Mon Sep 17 00:00:00 2001 From: Owl Bot Date: Fri, 6 May 2022 15:38:36 +0000 Subject: [PATCH 2/2] =?UTF-8?q?=F0=9F=A6=89=20Updates=20from=20OwlBot=20po?= =?UTF-8?q?st-processor?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --- scripts/changesummary.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/scripts/changesummary.py b/scripts/changesummary.py index 01e9bf8afe3..c6cd715ce2a 100644 --- a/scripts/changesummary.py +++ b/scripts/changesummary.py @@ -207,8 +207,7 @@ def _get_discovery_differences(self, filename): # children keys have been added. all_added = ( parent_added_agg[ - (parent_added_agg["Proportion"] == 1) - & parent_added_agg["Added"] + (parent_added_agg["Proportion"] == 1) & parent_added_agg["Added"] ][["Parent", "NumLevels"]] .sort_values("NumLevels", ascending=True) .Parent.to_list() @@ -219,8 +218,7 @@ def _get_discovery_differences(self, filename): # children keys have been deleted. all_deleted = ( parent_deleted_agg[ - (parent_deleted_agg["Proportion"] == 1) - & parent_deleted_agg["Deleted"] + (parent_deleted_agg["Proportion"] == 1) & parent_deleted_agg["Deleted"] ][["Parent", "NumLevels"]] .sort_values("NumLevels", ascending=True) .Parent.to_list()