Migrate AutoCompleteTextViewHolderFactory to compose #2899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LZRS
force-pushed
the
sdc-compose-autocompletetextview
branch
from
0c952a4 to
8d31f4b
Compare
LZRS
force-pushed
the
sdc-compose-autocompletetextview
branch
from
ab0e1e6 to
73146c0
Compare
FikriMilano
suggested changes
Nov 26, 2025
Comment on lines
+88
to
+96
| start = 16.dp, | ||
| top = | ||
| if (selectedOptions.isNotEmpty()) { | ||
| with(density) { chipContainerHeight.toDp() } + 16.dp | ||
| } else { | ||
| 16.dp | ||
| }, | ||
| end = 16.dp, | ||
| bottom = 16.dp, |
Contributor
There was a problem hiding this comment.
maybe we should use dimensionResource?
Comment on lines
+98
to
+101
|
|
||
| // TODO: Set text gravity using Modifier | ||
| // .align(Alignment.BottomCenter) | ||
| MultiAutoCompleteTextItem( |
Contributor
There was a problem hiding this comment.
should this todo be addressed in this pr?
github-project-automation
bot
moved this from New
to PR under Review
in Android FHIR SDK
FikriMilano
suggested changes
Nov 26, 2025
Comment on lines
+120
to
+123
| val questionnaireResponseAnswer = | ||
| questionnaireViewItem.enabledAnswerOptions | ||
| .first { it.value.identifierString(context) == answerOption.answerId } | ||
| .valueCoding |
Contributor
There was a problem hiding this comment.
should we use firstOrNull? I noticed it's being used in DropdownViewHolderFactory too
Collaborator
|
pr looks good. thanks. pls add a video. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2897
Description
Clear and concise code change description.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.