Fix formatting for super and self keywords

[DaelonSuzuka]

Fixes #890

[theXYZT]

I may be reading this wrong, but it doesn't seem like this fixes: [self] -> [ self ].

[DaelonSuzuka]

No it doesn't. (when would that even happen?)

[theXYZT]

No it doesn't. (when would that even happen?)

When you use 'self' as a key for a Dictionary.

[DaelonSuzuka]

Yes that's obvious but I'm struggling to imagine when I would ever want that.

[DaelonSuzuka]

@theXYZT can you think of any other cases?

[theXYZT]

In your image, is { self: self } supposed to be the formatted text?

[theXYZT]

Thinking about it, is there a reason why this can't be the simplification for part of this fix:

if (next === "]") {
    return "";
}

if (prev === "[") {
    return "";
}

Are there any cases where you want an opening square bracket / closing square bracket to be followed / preceded by a space?

But perhaps this is for a different pull request to experiment with.

[DaelonSuzuka]

In your image, is { self: self } supposed to be the formatted text?

Hm, I just doubled checked and other dict literals are not expanded here. I've been writing mostly ts lately and a similar object literal does have the extra padding.

Just checked python/ruff, and padding is not added to dict literals there.

I have intentionally avoided adding more rules for this syntax because my formatter does not modify indentation at all. A proper formatter would re-indent list/dict literals, collapse small ones onto one line, expand large ones onto multiple lines, etc. Mine is not smart enough to handle that so I've just left them alone.

Let me mess with it a bit more...

[DaelonSuzuka]

There we go, much better. I removed the special cases entirely and changed it to treat self/super like regular identifiers. Thanks!

[Calinou]

The lines being changed here should probably be removed entirely rather than commented out (since you can find them back using version control).

[theXYZT]

Is there anything blocking this from being pushed? I'd love to have a nightly build with this.