-
Notifications
You must be signed in to change notification settings - Fork 154
Use external hip and hipcub headers when HOOMD_GPU_PLATFORM=CUDA #2178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Builds fail with 7.1 on CUDA 12.
Also document Pixi installation instructions.
|
@mphoward, what do you think of using an external HIP library even when Ideally we could avoid this by using In any case, I won't merge this until |
|
Hmm, it isn't ideal to require CUDA users to download and compile HIP, but I agree this fix is substantially less work than getting Do you have a rough sense of when |
Description
find_package(hip)to find external headers.Motivation and context
CUDA 13 contains many breaking changes and the vendored headers do not support it.
By using external hip libraries, HOOMD-blue will gain support for new versions of CUDA as soon as upstream adds support (at this time the latest release of hipcub does not support CUDA 13).
conda-forge does not support
HIP_PLATFORM=nvidia(conda-forge/hip-feedstock#9) inhip-develand lacks ahipcubpackage entirely. Therefore, users that build HOOMD from source for NVIDIA GPUs will need to install hip and hipcub headers:How has this been tested?
HOOMD-blue compiles and passes tests with CUDA 12.9, rocm-systems:hip-version_7.2.53220, and rocm-libraries:rocm-7.1.0 locally. CI checks have been updated accordingly. Patches to hip and hipcub fix build errors with CUDA 12.5–12.8.
Checklist:
sphinx-doc/credits.rst) in the pull request source branch.CHANGELOG.rstfollowing the established format.