Skip to content
This repository was archived by the owner on Apr 6, 2025. It is now read-only.
This repository was archived by the owner on Apr 6, 2025. It is now read-only.

Double negatives #779

@glacials

Description

@glacials

Open this run: https://splits.io/861p

And hover over the second-to-last split in the timeline:

image

Looks like format_casual may have never worked for negatives and we just never noticed, because we tend to use pretty_difference for negative use cases.

This is two issues:

  • When format_casual displays a negative number, it shows two - characters instead of one
  • The possible timesave for this segment is negative which doesn't make sense. If it's us then this is a bug to be fixed, if this is a corrupted split file then we should at least hide the number instead of rendering one that doesn't make sense. Hopefully also find out how a file could get corrupted like this through normal use.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugIssues that are solved by repairing functionalitygood first issueIssues that don't need a ton of context to addresssmallIssues that probably won't take much work to address

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions