Objective
Bring the error messages in these 5 files up to the repo's error-message style guide.
Context
Issue #52163 asks to repair error messages in batches of 5 files max. The lint-error-messages workflow (see run https://github.com/github/gh-aw/actions/runs/31510578209/job/93862987189) flagged these files as low-compliance:
pkg/workflow/compiler_pre_activation_job.go: 5/17 compliant (29%)
pkg/workflow/tools_validation_github.go: 0/11 compliant (0%)
pkg/workflow/evals_config.go: 3/14 compliant (21%)
pkg/cli/spec.go: 6/17 compliant (35%)
pkg/cli/add_package_manifest.go: 15/26 compliant (57%)
Implementation Guidance
- Read
.github/skills/error-messages/SKILL.md for the style guide before editing.
- For each
fmt.Errorf / NewValidationError call flagged non-compliant, rewrite the message using the template: [what's wrong]. [what's expected]. [example of correct usage].
- Avoid standalone negative wording (
invalid, cannot, must, failed) without pairing it with expected behavior and a concrete fix.
- Use
NewValidationError(field, value, reason, suggestion) for *_validation.go files where applicable; use fmt.Errorf with %w wrapping for operational errors, adding recovery guidance.
- Keep changes surgical — do not alter error-handling logic or control flow, only message text.
Acceptance Criteria
Dependency Notes
Independent of other batches; can be worked in parallel with the other 7 sub-issues from this plan.
Generated by 🧑🤝🧑 Squad Plan · auto · 73.9 AIC · ⌖ 8.23 AIC · ⊞ 9.3K · ◷
Comment /squad-plan to run again
Objective
Bring the error messages in these 5 files up to the repo's error-message style guide.
Context
Issue #52163 asks to repair error messages in batches of 5 files max. The
lint-error-messagesworkflow (see run https://github.com/github/gh-aw/actions/runs/31510578209/job/93862987189) flagged these files as low-compliance:pkg/workflow/compiler_pre_activation_job.go: 5/17 compliant (29%)pkg/workflow/tools_validation_github.go: 0/11 compliant (0%)pkg/workflow/evals_config.go: 3/14 compliant (21%)pkg/cli/spec.go: 6/17 compliant (35%)pkg/cli/add_package_manifest.go: 15/26 compliant (57%)Implementation Guidance
.github/skills/error-messages/SKILL.mdfor the style guide before editing.fmt.Errorf/NewValidationErrorcall flagged non-compliant, rewrite the message using the template:[what's wrong]. [what's expected]. [example of correct usage].invalid,cannot,must,failed) without pairing it with expected behavior and a concrete fix.NewValidationError(field, value, reason, suggestion)for*_validation.gofiles where applicable; usefmt.Errorfwith%wwrapping for operational errors, adding recovery guidance.Acceptance Criteria
gh awtooling used by that workflow) shows improved/100% compliance for these 5 files.make fmtrun after changes.make test-unit(or targeted package tests forpkg/workflowandpkg/cli) passes.Dependency Notes
Independent of other batches; can be worked in parallel with the other 7 sub-issues from this plan.