[terminal-stylist] Terminal Stylist Report: Console Output & Charmbracelet Ecosystem Analysis

[github-actions[bot]]

Terminal Stylist Report — Console Output & Charmbracelet Ecosystem Analysis

The codebase has a mature, well-centralized console formatting layer (pkg/console, pkg/styles) built on charm.land/lipgloss/v2 and charm.land/huh/v2. Overall consistency is high; only a couple of minor fmt.Print bypasses and no significant anti-patterns were found.

Key metrics

• fmt.Print* in production code (non-test, non-linter-testdata): 2 occurrences (pkg/cli/status_command.go, pkg/cli/view_command.go) — both print pre-rendered console.Render* output, not raw unstyled text.
• console.* formatter call sites: 2,000+, dominated by FormatInfoMessage (676), FormatWarningMessage (530), FormatSuccessMessage (216) — strong adoption of the shared formatting API.
• Files importing charm.land/lipgloss/v2: 7 (pkg/styles/theme.go, pkg/styles/huh_theme.go, pkg/console/console.go, pkg/console/banner.go, pkg/logger/logger.go, pkg/cli/status_command.go, pkg/cli/mcp_inspect.go).
• Files importing charm.land/huh/v2: 16, including a dedicated pkg/styles/huh_theme.go theme and pkg/console/{confirm,input,prompt_form,list}.go wrapper helpers.
• Raw ANSI escape sequences: only 2 legitimate uses — a screen/line-clear constant (pkg/console/terminal.go) and an ANSI-stripping utility (pkg/stringutil/ansi.go). No ad-hoc styling via raw escapes.

Lipgloss usage details

• Adaptive colors: pkg/styles/theme.go defines a custom adaptiveColor type with light/dark hex pairs (Dracula-inspired dark palette), driven by a startup HasDarkBackground probe — this is a solid, well-documented pattern, including a Windows-specific safety skip (STATUS_DLL_INIT_FAILED crash avoidance under ConPTY).
• Tables: pkg/console/console.go implements RenderTable/buildTableStyleFunc using charm.land/lipgloss/v2/table, with per-row/column styling and TableConfig abstraction — no manual column-padding logic found elsewhere, so there's no duplicated ad-hoc table code to consolidate.
• Layout: console.go also uses Border(lipgloss.DoubleBorder()/NormalBorder()), Align(lipgloss.Center), and lipgloss.JoinVertical for boxed/plan output — consistent with CSS-like composition best practices.
• TTY detection: styling application is centralized through applyStyle/applyStdoutStyleWithTTY/applyStderrStyleWithTTY helpers in console.go, which take an injectable ttyCheck function — good for testability and preventing stray ANSI codes when output is piped/redirected.
• Opportunity: RenderStruct/RenderTable output is still routed through fmt.Print(console.RenderStruct(...)) in status_command.go and a bare fmt.Print(output) in view_command.go. Since the string is already lipgloss-rendered, this is stylistically fine, but consider adding a console.PrintRendered(w io.Writer, s string) thin wrapper so no call site uses raw fmt.Print* at all — purely for auditability/lint-friendliness, not a functional bug.

Huh usage details

• Central theme: pkg/styles/huh_theme.go provides styles.HuhTheme, consumed uniformly via console.NewForm/NewInputForm/NewSelectForm/NewConfirmForm in pkg/console/prompt_form.go — every interactive form in pkg/cli/add_interactive_*.go, run_interactive.go, bootstrap_profile_*.go, and engine_secrets.go goes through these wrappers rather than instantiating huh.NewForm directly, which is the correct centralization pattern.
• Accessibility: NewForm always calls .WithAccessible(console.IsAccessibleMode()), and IsAccessibleMode() checks ACCESSIBLE, TERM=dumb, and NO_COLOR env vars — matches Huh's documented accessibility-mode guidance and correctly triggers on standard no-color conventions.
• TTY fallback: Both ConfirmAction (confirm.go) and PromptSecretInput (input.go) check tty.IsStderrTerminal() before invoking the Huh form, falling back to a plain-text prompt (showTextConfirm) or erroring out gracefully in non-interactive environments — this is the right defensive pattern for CI/piped usage.
• Validation: Inline Validate(func(s string) error {...}) closures are used appropriately (e.g., empty-value checks in PromptSecretInput).
• Cancellation handling: console.IsCancelled(err) wraps errors.Is(err, huh.ErrUserAborted) for a single, reusable way to distinguish Ctrl-C/Esc from real errors — avoids duplicated errors.Is checks across call sites.

Recommendations

1. No urgent fixes required — the two fmt.Print call sites already print lipgloss-rendered strings; low-priority cleanup only (wrap in a console.PrintRendered helper for consistency/auditability).
2. Consider documenting the console.New*Form wrapper convention in pkg/console/doc.go so new interactive prompts don't bypass styles.HuhTheme/accessibility wiring by calling huh.NewForm directly.
3. No hardcoded (non-adaptive) colors, no manual ANSI styling, and no duplicated table-formatting logic were found — the existing pkg/console + pkg/styles abstraction is doing its job well.

References: N/A — this analysis covered static source only, no workflow run was involved.

Generated by 💄 Terminal Stylist · auto · 25.3 AIC · ⌖ 3.55 AIC · ⊞ 8.2K · ◷

• expires on Aug 5, 2026, 1:36 AM UTC-08:00

[github-actions[bot]]

This discussion was automatically closed because it expired on 2026-08-05T09:36:34.906Z.

Closed by Workflow