Skip to content

Commit 6bc1d52

Browse files
authored
Tighten golden-test coverage: remove dead console fixtures and goldenize wasm all-engines (#33248)
1 parent 176ca18 commit 6bc1d52

22 files changed

Lines changed: 3229 additions & 88 deletions

pkg/console/golden_test.go

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ import (
1010
"github.com/charmbracelet/x/exp/golden"
1111
)
1212

13+
// Keep subtest names path-safe (no "/") since golden.RequireEqual maps them to testdata paths.
14+
1315
// TestGolden_TableRendering tests table rendering with different configurations
1416
func TestGolden_TableRendering(t *testing.T) {
1517
tests := []struct {
@@ -129,8 +131,6 @@ func TestGolden_BoxRendering(t *testing.T) {
129131
}
130132
}
131133

132-
// TestGolden_LayoutBoxRendering tests layout box rendering (returns string)
133-
134134
// TestGolden_ErrorFormatting tests error formatting with context
135135
func TestGolden_ErrorFormatting(t *testing.T) {
136136
tests := []struct {
@@ -317,10 +317,6 @@ func TestGolden_MessageFormatting(t *testing.T) {
317317
}
318318
}
319319

320-
// TestGolden_LayoutComposition tests composing multiple layout elements
321-
322-
// TestGolden_LayoutEmphasisBox tests emphasis boxes with different colors
323-
324320
// TestGolden_InfoSection tests info section rendering
325321
func TestGolden_InfoSection(t *testing.T) {
326322
tests := []struct {

pkg/console/testdata/TestGolden_LayoutBoxRendering/layout_medium.golden

Lines changed: 0 additions & 3 deletions
This file was deleted.

pkg/console/testdata/TestGolden_LayoutBoxRendering/layout_narrow.golden

Lines changed: 0 additions & 3 deletions
This file was deleted.

pkg/console/testdata/TestGolden_LayoutBoxRendering/layout_wide.golden

Lines changed: 0 additions & 3 deletions
This file was deleted.

pkg/console/testdata/TestGolden_LayoutComposition/complete_composition.golden

Lines changed: 0 additions & 10 deletions
This file was deleted.

pkg/console/testdata/TestGolden_LayoutComposition/multiple_emphasis_boxes.golden

Lines changed: 0 additions & 11 deletions
This file was deleted.

pkg/console/testdata/TestGolden_LayoutComposition/title_and_info.golden

Lines changed: 0 additions & 6 deletions
This file was deleted.

pkg/console/testdata/TestGolden_LayoutEmphasisBox/error_box.golden

Lines changed: 0 additions & 3 deletions
This file was deleted.

pkg/console/testdata/TestGolden_LayoutEmphasisBox/info_box.golden

Lines changed: 0 additions & 3 deletions
This file was deleted.

pkg/console/testdata/TestGolden_LayoutEmphasisBox/success_box.golden

Lines changed: 0 additions & 3 deletions
This file was deleted.

0 commit comments

Comments
 (0)