JS: Add use cache directives from Next.js 16 #20938
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-mc
reviewed
Nov 29, 2025
.vscode/settings.json
Outdated
Comment on lines
5
to
6
| "editor.suggest.matchOnWordStartOnly": false, | ||
| "editor.formatOnSave": false |
Contributor
There was a problem hiding this comment.
I think you committed this by mistake.
tesseractjh
force-pushed
the
js/use-cache-directives
branch
from
5b7c2d0 to
c4f6606
Compare
asgerf
reviewed
Dec 1, 2025
| * ``` | ||
| */ | ||
| class UseCacheDirective extends KnownDirective { | ||
| UseCacheDirective() { this.getDirectiveText().regexpMatch("use cache(: (remote|private))?") } |
Contributor
There was a problem hiding this comment.
Suggested change
| UseCacheDirective() { this.getDirectiveText().regexpMatch("use cache(: (remote|private))?") } | |
| UseCacheDirective() { this.getDirectiveText().regexpMatch("use cache(:.*)?") } |
It seems better to match anything here so we don't have to come back and update it if more cache modes are added in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
use cachedirectives(includinguse cache: remote,use cache: private) for Next.js 16