Skip to content

Commit 59fd1ff

Browse files
authored
fix(metric_stats): Fix tests and mocks (#99290)
Continuation of #99276. `sentry-relay` has been bumped to a newest version, so now we can remove `metric_stats` from mocks.
1 parent ba109b3 commit 59fd1ff

File tree

1 file changed

+0
-17
lines changed

1 file changed

+0
-17
lines changed

tests/sentry/api/endpoints/test_relay_globalconfig_v3.py

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -44,14 +44,12 @@ def inner(version, global_):
4444
"replay.relay-snuba-publishing-disabled.sample-rate": 1.0,
4545
"relay.metric-bucket-distribution-encodings": {
4646
"custom": "array",
47-
"metric_stats": "array",
4847
"profiles": "array",
4948
"spans": "array",
5049
"transactions": "array",
5150
},
5251
"relay.metric-bucket-set-encodings": {
5352
"custom": "base64",
54-
"metric_stats": "base64",
5553
"profiles": "base64",
5654
"spans": "base64",
5755
"transactions": "base64",
@@ -67,21 +65,6 @@ def test_global_config() -> None:
6765
if not config["options"]["relay.span-normalization.allowed_hosts"]:
6866
del config["options"]["relay.span-normalization.allowed_hosts"]
6967

70-
# NOTE (vgrozdanic): temporary fix for the test, until metric_stats is completely removed
71-
# from sentry codebase. It has been removed from relay, without being first removed from
72-
# sentry
73-
if "metric_stats" in config["options"]["relay.metric-bucket-distribution-encodings"]:
74-
del config["options"]["relay.metric-bucket-distribution-encodings"]["metric_stats"]
75-
76-
if "metric_stats" in normalized["options"]["relay.metric-bucket-distribution-encodings"]:
77-
del normalized["options"]["relay.metric-bucket-distribution-encodings"]["metric_stats"]
78-
79-
if "metric_stats" in config["options"]["relay.metric-bucket-set-encodings"]:
80-
del config["options"]["relay.metric-bucket-set-encodings"]["metric_stats"]
81-
82-
if "metric_stats" in normalized["options"]["relay.metric-bucket-set-encodings"]:
83-
del normalized["options"]["relay.metric-bucket-set-encodings"]["metric_stats"]
84-
8568
assert normalized == config
8669

8770

0 commit comments

Comments
 (0)