Skip to content

Commit c032d3e

Browse files
committed
feat(replay): ignore background-image when blockAllMedia is enabled
Pass `ignoreCSSAttributes` with `background-imgae` to ignore background images when `blockAllMedia` is enabled. `ignoreCSSAttributes` was expanded in [this PR](getsentry/rrweb#252) so that it also works for inline styles.
1 parent fd26569 commit c032d3e

File tree

4 files changed

+25
-24
lines changed

4 files changed

+25
-24
lines changed

packages/replay-canvas/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@
6666
},
6767
"homepage": "https://docs.sentry.io/platforms/javascript/session-replay/",
6868
"devDependencies": {
69-
"@sentry-internal/rrweb": "2.37.0"
69+
"@sentry-internal/rrweb": "2.39.0"
7070
},
7171
"dependencies": {
7272
"@sentry-internal/replay": "10.21.0",

packages/replay-internal/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,8 @@
8282
"devDependencies": {
8383
"@babel/core": "^7.27.7",
8484
"@sentry-internal/replay-worker": "10.21.0",
85-
"@sentry-internal/rrweb": "2.37.0",
86-
"@sentry-internal/rrweb-snapshot": "2.37.0",
85+
"@sentry-internal/rrweb": "2.39.0",
86+
"@sentry-internal/rrweb-snapshot": "2.39.0",
8787
"fflate": "0.8.2",
8888
"jest-matcher-utils": "^29.0.0",
8989
"jsdom-worker": "^0.3.0",

packages/replay-internal/src/integration.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,7 @@ export class Replay implements Integration {
187187
this._recordingOptions.blockSelector = !this._recordingOptions.blockSelector
188188
? MEDIA_SELECTORS
189189
: `${this._recordingOptions.blockSelector},${MEDIA_SELECTORS}`;
190+
this._recordingOptions.ignoreCSSAttributes = new Set(['background-image']);
190191
}
191192

192193
if (this._isInitialized && isBrowser()) {

yarn.lock

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -6951,22 +6951,22 @@
69516951
dependencies:
69526952
"@sentry-internal/rrweb-snapshot" "2.34.0"
69536953

6954-
"@sentry-internal/rrdom@2.37.0":
6955-
version "2.37.0"
6956-
resolved "https://registry.yarnpkg.com/@sentry-internal/rrdom/-/rrdom-2.37.0.tgz#1aaf382eb7b543d7c256d31b73868e81e6649fbb"
6957-
integrity sha512-Wj6W4HP6kVYL1oenYq+Ec7QKtsq1Btk/acFLfZ/O7fygLVeAM0KZ4JZirPWdJmpeNNIk1YN7a8C7CfCiM014Ag==
6954+
"@sentry-internal/rrdom@2.39.0":
6955+
version "2.39.0"
6956+
resolved "https://registry.yarnpkg.com/@sentry-internal/rrdom/-/rrdom-2.39.0.tgz#b758ad27a6a68e6a1493daefd3fecbbf14338b52"
6957+
integrity sha512-m6BXCfw4ODu32uCNORngt5vXtIwqwM5+1vCbLvdtE9jQWCDzimgiQkFrw+v0/Wa0lAeVfOQnqq3un+oNpQ/RdQ==
69586958
dependencies:
6959-
"@sentry-internal/rrweb-snapshot" "2.37.0"
6959+
"@sentry-internal/rrweb-snapshot" "2.39.0"
69606960

69616961
"@sentry-internal/[email protected]":
69626962
version "2.34.0"
69636963
resolved "https://registry.yarnpkg.com/@sentry-internal/rrweb-snapshot/-/rrweb-snapshot-2.34.0.tgz#79c2049b6c887e3c128d5fa80d6f745a61dd0e68"
69646964
integrity sha512-9Tb8jwVufn5GLV0d/CTuoZWo2O06ZB+xWeTJdEkbtJ6PAmO/Q7GQI3uNIx0pfFEnXP+0Km8CKKxpwkEM0z2m6w==
69656965

6966-
"@sentry-internal/rrweb-snapshot@2.37.0":
6967-
version "2.37.0"
6968-
resolved "https://registry.yarnpkg.com/@sentry-internal/rrweb-snapshot/-/rrweb-snapshot-2.37.0.tgz#2081d1827a108a08cab219234952744e6e79c06b"
6969-
integrity sha512-fu2/Fd5J5gJrAgQgl9WykVPQkMjo+9MVFy4Y88STTP3WWsLu1u75YAQM6Lr1/tLEykoQ4NecmNDdcz/DiB/nNg==
6966+
"@sentry-internal/rrweb-snapshot@2.39.0":
6967+
version "2.39.0"
6968+
resolved "https://registry.yarnpkg.com/@sentry-internal/rrweb-snapshot/-/rrweb-snapshot-2.39.0.tgz#dbc772ad048205911cb480ace3aad8c2cbbb89e7"
6969+
integrity sha512-L0Ww4eU+NO/wfJlKvx3fndK20pRyVaDBiNTPiBtrfYtvtzfjiPHXzymOAD8elJZ+7S6Sbve1CKy2rbTSKtJS/w==
69706970

69716971
"@sentry-internal/[email protected]":
69726972
version "2.34.0"
@@ -6976,12 +6976,12 @@
69766976
"@sentry-internal/rrweb-snapshot" "2.34.0"
69776977
"@types/css-font-loading-module" "0.0.7"
69786978

6979-
"@sentry-internal/rrweb-types@2.37.0":
6980-
version "2.37.0"
6981-
resolved "https://registry.yarnpkg.com/@sentry-internal/rrweb-types/-/rrweb-types-2.37.0.tgz#edc91ee032896788fa9a6f96c76f1f6dd7c9f538"
6982-
integrity sha512-ydtHzfGFO6Tyw4n7yOLUrdaNKmRdyaVfqNgObEbEgO/qobzxBV5zf8eNApTayy6SOji3NrF8PpJzm55OX/ChNA==
6979+
"@sentry-internal/rrweb-types@2.39.0":
6980+
version "2.39.0"
6981+
resolved "https://registry.yarnpkg.com/@sentry-internal/rrweb-types/-/rrweb-types-2.39.0.tgz#54eb91f749d5d28a6ef25a34a39d20675eacd761"
6982+
integrity sha512-9fLBNitdtEEf+5wqZUYv6rJeb3sUJqemNCECPMlA1p/9fpmzEw1kZbsOleNG4F77F46zqf8qK2NWPQDvuzQg1Q==
69836983
dependencies:
6984-
"@sentry-internal/rrweb-snapshot" "2.37.0"
6984+
"@sentry-internal/rrweb-snapshot" "2.39.0"
69856985
"@types/css-font-loading-module" "0.0.7"
69866986

69876987
"@sentry-internal/[email protected]":
@@ -6998,14 +6998,14 @@
69986998
fflate "^0.4.4"
69996999
mitt "^3.0.0"
70007000

7001-
"@sentry-internal/rrweb@2.37.0":
7002-
version "2.37.0"
7003-
resolved "https://registry.yarnpkg.com/@sentry-internal/rrweb/-/rrweb-2.37.0.tgz#8ea0eb906e194060c60f4a6af4a0d3a16d52cdec"
7004-
integrity sha512-erN53M1WSPGpsMw+iVX6qWhI4id41+2AXcnALoB2JIyL/Q1W8f2loq/a4PxWkhaaq7mtGiHTmNTbks8Qgrsl9g==
7001+
"@sentry-internal/rrweb@2.39.0":
7002+
version "2.39.0"
7003+
resolved "https://registry.yarnpkg.com/@sentry-internal/rrweb/-/rrweb-2.39.0.tgz#3cfc8eef60cb5f9b97047867d7d18640d0dba3d2"
7004+
integrity sha512-0SegNtlxNvmCW+kYMwCi81QbWUxjkmc2fwQlg9S2FMjoB3RDbFGIyPsfu2PbYz8mp8FmleEDFLk/Lo0KjljHEA==
70057005
dependencies:
7006-
"@sentry-internal/rrdom" "2.37.0"
7007-
"@sentry-internal/rrweb-snapshot" "2.37.0"
7008-
"@sentry-internal/rrweb-types" "2.37.0"
7006+
"@sentry-internal/rrdom" "2.39.0"
7007+
"@sentry-internal/rrweb-snapshot" "2.39.0"
7008+
"@sentry-internal/rrweb-types" "2.39.0"
70097009
"@types/css-font-loading-module" "0.0.7"
70107010
"@xstate/fsm" "^1.4.0"
70117011
base64-arraybuffer "^1.0.1"

0 commit comments

Comments
 (0)