Skip to content

Commit af997fb

Browse files
authored
chore: Manually upgrade gdUnit4 to v6.0.0 (#407)
1 parent 023e73c commit af997fb

File tree

5 files changed

+9
-35
lines changed

5 files changed

+9
-35
lines changed

.github/actions/prepare-testing/action.yml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,10 +98,6 @@ runs:
9898
shell: bash
9999
run: |
100100
scons project/addons/gdUnit4
101-
echo "Applying gdUnit4 patch"
102-
cd modules/gdUnit4
103-
# NOTE: Patching gdUnit4 as it errors out in Godot 4.5.
104-
git apply ../gdunit4.patch
105101
106102
- name: Prepare project
107103
shell: bash

modules/gdUnit4

Submodule gdUnit4 updated 151 files

modules/gdunit4.patch

Lines changed: 0 additions & 22 deletions
This file was deleted.

project/test/isolated/test_limit_throttling.gd

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,14 @@ func _before_send(_ev: SentryEvent) -> SentryEvent:
2727

2828
## Only two errors should be logged within the assigned time window.
2929
func test_throttling_limits() -> void:
30-
var monitor := monitor_signals(self, false)
30+
monitor_signals(self, false)
31+
3132
push_error("dummy-error")
3233
push_error("dummy-error")
3334
push_error("dummy-error")
34-
await assert_signal(monitor).is_emitted("callback_processed")
35-
await assert_signal(monitor).is_emitted("callback_processed")
36-
await get_tree().create_timer(0.1).timeout
35+
36+
await assert_signal(self).is_emitted("callback_processed")
37+
await get_tree().process_frame # allow all events to process
3738
assert_int(_num_events).is_equal(2)
3839

3940
# Wait for throttling window to expire.
@@ -42,7 +43,6 @@ func test_throttling_limits() -> void:
4243
push_error("dummy-error")
4344
push_error("dummy-error")
4445
push_error("dummy-error")
45-
await assert_signal(monitor).is_emitted("callback_processed")
46-
await assert_signal(monitor).is_emitted("callback_processed")
47-
await get_tree().create_timer(0.1).timeout
46+
await assert_signal(self).is_emitted("callback_processed")
47+
await get_tree().process_frame # allow all events to process
4848
assert_int(_num_events).is_equal(4)

project/test/util/json_assert

0 commit comments

Comments
 (0)