fix: Move file manager URL constructing to Swift #6899
+10
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahsmartin
requested review from
itaybre,
philipphofmann and
philprime
as code owners
noahsmartin
force-pushed
the
fixURLConstructingCrash
branch
from
551910d to
d27ad64
Compare
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
Member
philipphofmann
left a comment
philipphofmann
left a comment
There was a problem hiding this comment.
@noahsmartin it would be great to add a test for this if possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ObjC version of this URL constructing can return nil if the string provided is an empty string in which case our code would crash. To protect against this we can migrate a bit more of this file manager code to Swift and guarantee it won't crash
Closes #6900