Skip to content

Commit 09e8b33

Browse files
chore(proguard): Deprecate --android-manifest argument (#2891)
### Description The `sentry-cli upload-proguard` command's `--android-manifest` argument is a no-op; therefore, we are deprecating it. ### Issues - Resolves #2875 - Resolves [CLI-201](https://linear.app/getsentry/issue/CLI-201/deprecate-upload-proguards-android-manifest-argument)
1 parent dac9ece commit 09e8b33

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
### Deprecations
66

77
- Deprecated the `upload-proguard` subcommand's `--platform` flag ([#2863](https://github.com/getsentry/sentry-cli/pull/2863)). This flag appears to have been a no-op for some time, so we will remove it in the next major.
8+
- Deprecated the `upload-proguard` subcommand's `--android-manifest` flag ([#2891](https://github.com/getsentry/sentry-cli/pull/2891)). This flag appears to have been a no-op for some time, so we will remove it in the next major.
89

910
## 2.57.0
1011

src/commands/upload_proguard.rs

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,10 @@ pub fn make_command(command: Command) -> Command {
111111
.value_name("PATH")
112112
.conflicts_with("app_id")
113113
.hide(true)
114-
.help("Read version and version code from an Android manifest file."),
114+
.help(
115+
"[DEPRECATED] This flag is a no-op, scheduled \
116+
for removal in Sentry CLI 3.0.0.",
117+
),
115118
)
116119
.arg(
117120
Arg::new("write_properties")
@@ -154,6 +157,14 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
154157
);
155158
}
156159

160+
if matches.get_one::<String>("android_manifest").is_some() {
161+
log::warn!(
162+
"[DEPRECATION NOTICE] The --android-manifest argument is deprecated, \
163+
and is scheduled for removal in Sentry CLI 3.0.0. \
164+
The argument is a no-op."
165+
);
166+
}
167+
157168
let paths: Vec<_> = match matches.get_many::<String>("paths") {
158169
Some(paths) => paths.collect(),
159170
None => {

0 commit comments

Comments
 (0)