Skip to content

Commit 02c9b01

Browse files
chore(proguard): Remove --platform argument
- Resolves #2851 - Resolves [CLI-193](https://linear.app/getsentry/issue/CLI-193/remove-upload-proguard-platform-flag)
1 parent 8355acc commit 02c9b01

File tree

3 files changed

+5
-23
lines changed

3 files changed

+5
-23
lines changed

CHANGELOG.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ we should rename this section to "Unreleased" -->
1818
- `SENTRY_API_KEY` environment variable
1919
- `api_key` configuration file field
2020
- `apiKey` option in the JavaScript API
21-
- Removed the `upload-proguard` subcommand's `--app-id`, `--version`, `--version-code`, and `--android-manifest` arguments ([#2876](https://github.com/getsentry/sentry-cli/pull/2876), [#2940](https://github.com/getsentry/sentry-cli/pull/2940)). Users using these arguments should stop using them, as they are unnecessary. The information passed to these arguments is no longer visible in Sentry.
21+
- Removed the `upload-proguard` subcommand's `--app-id`, `--version`, `--version-code`, `--android-manifest`, and `--platform` arguments ([#2876](https://github.com/getsentry/sentry-cli/pull/2876), [#2940](https://github.com/getsentry/sentry-cli/pull/2940), [#XXXX](TODO)). Users using these arguments should stop using them, as they are unnecessary. The information passed to these arguments is no longer visible in Sentry.
2222

2323
### Improvements
2424

src/commands/upload_proguard.rs

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -28,16 +28,6 @@ pub fn make_command(command: Command) -> Command {
2828
.num_args(1..)
2929
.action(ArgAction::Append),
3030
)
31-
.arg(
32-
Arg::new("platform")
33-
.hide(true)
34-
.long("platform")
35-
.value_name("PLATFORM")
36-
.help(
37-
"[DEPRECATED] This flag is a no-op, scheduled \
38-
for removal in Sentry CLI 3.0.0.",
39-
),
40-
)
4131
.arg(
4232
Arg::new("no_upload")
4333
.long("no-upload")
@@ -82,14 +72,6 @@ pub fn make_command(command: Command) -> Command {
8272
}
8373

8474
pub fn execute(matches: &ArgMatches) -> Result<()> {
85-
if matches.get_one::<String>("platform").is_some() {
86-
log::warn!(
87-
"[DEPRECATION NOTICE] The --platform argument is deprecated, \
88-
and is scheduled for removal in Sentry CLI 3.0.0. \
89-
The argument is a no-op."
90-
);
91-
}
92-
9375
let paths: Vec<_> = match matches.get_many::<String>("paths") {
9476
Some(paths) => paths.collect(),
9577
None => {

tests/integration/_cases/upload_proguard/upload_proguard-help.trycmd

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,17 +14,17 @@ Options:
1414
in key:value format.
1515
-p, --project <PROJECT> The project ID or slug.
1616
--auth-token <AUTH_TOKEN> Use the given Sentry auth token.
17-
--log-level <LOG_LEVEL> Set the log output verbosity. [possible values: trace, debug, info,
18-
warn, error]
1917
--no-upload Disable the actual upload.
2018
This runs all steps for the processing but does not trigger the
2119
upload. This is useful if you just want to verify the mapping
2220
files and write the proguard UUIDs into a properties file.
21+
--log-level <LOG_LEVEL> Set the log output verbosity. [possible values: trace, debug, info,
22+
warn, error]
23+
--write-properties <PATH> Write the UUIDs for the processed mapping files into the given
24+
properties file.
2325
--quiet Do not print any output while preserving correct exit code. This
2426
flag is currently implemented only for selected subcommands.
2527
[aliases: --silent]
26-
--write-properties <PATH> Write the UUIDs for the processed mapping files into the given
27-
properties file.
2828
--require-one Requires at least one file to upload or the command will error.
2929
-u, --uuid <UUID> Explicitly override the UUID of the mapping file with another one.
3030
This should be used with caution as it means that you can upload

0 commit comments

Comments
 (0)