tests: Validate unescaped arguments

In commit 6f045bb, we modified the various 'git-am' wrappers so that
additional arguments to be passed to 'git-am' did not need to be
escaped, such that:

  git-am apply 123 -- --signoff

would become:

  git-am apply 123 --signoff

Modify the unit tests for these commands to validate this behavior. We
don't bother validating the older behavior as this is standard *nix
behavior.

Signed-off-by: Stephen Finucane <[email protected]>

Author: stephenfin

tests/test_bundle.py

@@ -83,7 +83,7 @@ def test_apply_with_args(self, mock_git_am, mock_download,
         mock_download.return_value = 'test.patch'
 
         runner = CLIRunner()
-        result = runner.invoke(bundle.apply_cmd, ['123', '--', '-3'])
+        result = runner.invoke(bundle.apply_cmd, ['123', '-3'])
 
         assert result.exit_code == 0, result
         mock_get_bundle.assert_called_once_with('123')

tests/test_patch.py

@@ -64,7 +64,7 @@ def test_apply_with_args(self, mock_git_am, mock_download, mock_detail):
         mock_download.return_value = object()
 
         runner = CLIRunner()
-        result = runner.invoke(patch.apply_cmd, ['123', '--', '-3'])
+        result = runner.invoke(patch.apply_cmd, ['123', '-3'])
 
         assert result.exit_code == 0, result
         mock_detail.assert_called_once_with('patches', 123)

tests/test_series.py

@@ -34,7 +34,7 @@ def test_apply_with_args(self, mock_git_am, mock_download, mock_detail):
         mock_download.return_value = 'test.patch'
 
         runner = CLIRunner()
-        result = runner.invoke(series.apply_cmd, ['123', '--', '-3'])
+        result = runner.invoke(series.apply_cmd, ['123', '-3'])
 
         assert result.exit_code == 0, result
         mock_detail.assert_called_once_with('series', 123)