Skip to content

Commit 42f851f

Browse files
authored
Merge pull request #874 from getmaxun/recorder-ui-shift
fix: unwanted overflow in recorder
2 parents 2b85a04 + 5c8da47 commit 42f851f

File tree

4 files changed

+16
-15
lines changed

4 files changed

+16
-15
lines changed

src/components/browser/BrowserRecordingSave.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,8 @@ const BrowserRecordingSave = () => {
143143
overflow: 'hidden',
144144
display: 'flex',
145145
justifyContent: 'space-between',
146-
height: "48px"
146+
height: "48px",
147+
marginLeft: '10px'
147148
}}>
148149
<Button
149150
onClick={() => setOpenDiscardModal(true)}

src/components/recorder/RightSidePanel.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -534,7 +534,7 @@ export const RightSidePanel: React.FC<RightSidePanelProps> = ({ onFinishCapture
534534
const isDarkMode = theme.darkMode;
535535

536536
return (
537-
<Paper sx={{ height: panelHeight, width: 'auto', alignItems: "center", background: 'inherit' }} id="browser-actions" elevation={0}>
537+
<Paper sx={{ height: panelHeight, width: 'auto', alignItems: "center", background: 'inherit', position: "relative", border: "none" }} id="browser-actions" elevation={0}>
538538
<ActionDescriptionBox isDarkMode={isDarkMode} />
539539
<Box display="flex" flexDirection="column" gap={2} style={{ margin: '13px' }}>
540540
{!isAnyActionActive && (

src/helpers/dimensionUtils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ export const getResponsiveDimensions = (): AppDimensions => {
7373
browserWidth,
7474
browserHeight,
7575
panelHeight: browserHeight + 137,
76-
outputPreviewHeight: windowHeight * 0.7,
76+
outputPreviewHeight: windowHeight * 0.9,
7777
outputPreviewWidth,
7878
canvasWidth: browserWidth,
7979
canvasHeight: browserHeight

src/pages/PageWrapper.tsx

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ export const PageWrapper = () => {
5555
const sessionParam = urlParams.get('session');
5656
const storedSessionId = getTabState('recordingSessionId');
5757
const storedRecordingUrl = getTabState('recordingUrl');
58-
58+
5959
if (location.pathname === '/recording-setup' && sessionParam && sessionParam === storedSessionId) {
6060
setBrowserId('new-recording');
6161
setRecordingName('');
@@ -67,14 +67,14 @@ export const PageWrapper = () => {
6767

6868
navigate('/recording');
6969
}
70-
else if (location.pathname === '/recording' ||
71-
(getTabState('nextTabIsRecording') === 'true' && sessionParam === storedSessionId)) {
70+
else if (location.pathname === '/recording' ||
71+
(getTabState('nextTabIsRecording') === 'true' && sessionParam === storedSessionId)) {
7272
setIsRecordingMode(true);
73-
73+
7474
if (location.pathname !== '/recording') {
7575
navigate('/recording');
7676
}
77-
77+
7878
window.sessionStorage.removeItem('nextTabIsRecording');
7979
} else if (tabMode === 'main') {
8080
console.log('Tab is in main application mode');
@@ -88,26 +88,26 @@ export const PageWrapper = () => {
8888

8989
const isAuthPage = location.pathname === '/login' || location.pathname === '/register';
9090
const isRecordingPage = location.pathname === '/recording';
91-
91+
9292
return (
9393
<div>
9494
<AuthProvider>
9595
<SocketProvider>
9696
<React.Fragment>
9797
{/* Show NavBar only for main app pages, not for recording pages */}
9898
{!isRecordingPage && (
99-
<Box sx={{
100-
position: 'sticky',
101-
top: 0,
99+
<Box sx={{
100+
position: 'sticky',
101+
top: 0,
102102
zIndex: 1100,
103103
backgroundColor: 'background.paper'
104104
}}>
105105
<NavBar recordingName={recordingName} isRecording={false} />
106106
</Box>
107107
)}
108-
<Box sx={{
109-
display: isAuthPage || isRecordingPage ? 'block' : 'flex',
110-
minHeight: isAuthPage || isRecordingPage ? '100vh' : 'calc(100vh - 64px)'
108+
<Box sx={{
109+
display: isAuthPage ? 'block' : 'flex',
110+
minHeight: isAuthPage ? '100vh' : 'calc(100vh - 64px)'
111111
}}>
112112
<Routes>
113113
<Route element={<UserRoute />}>

0 commit comments

Comments
 (0)