-
Notifications
You must be signed in to change notification settings - Fork 127
Update ee_profiler.py #441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -92,12 +92,20 @@ def _to_dict(self, input: str) -> dict: | |
| else desc, # Description can have multiple words | ||
| } | ||
|
|
||
| # The default splitting splits the description and only takes | ||
| # the first word so we need to join the trailing words dropped by the zip. | ||
| fix_description = False | ||
| if headers[-1] == "Description": | ||
| fix_description = True | ||
| # Process each line of data after the header | ||
| for line in lines[1:]: | ||
| # Split the line by spaces, considering multiple spaces as a separator | ||
| # Handle missing values denoted by "-" | ||
| parts = line.split() | ||
| part_result = dict(zip(headers, parts)) | ||
|
|
||
| if fix_description: | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. the evaluation of the fix_description could actually be done directly in the if statement with the comment associated so it's clear it's only necessary there. |
||
| part_result["Description"] = " ".join(parts[len(headers) - 1 :]) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. actually open question, if we join them all, the other should not be affected as they are a 1 item list right ? So you might be able to simply add this mechanism to all part_results instead of just the description, avoiding the all |
||
| # Populate the dictionary with values for each column | ||
| for head in headers: | ||
| result[head].append(process[head](part_result[head])) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could be done in 1 line: