RangeError: Cannot use large units

[nulltoken]

Using lib v0.3.0

Works:

const date: Temporal.PlainDate = Temporal.PlainDate.from("2024-03-15");
const startOfZonedDay = date.toZonedDateTime("UTC");
const oneDay = Temporal.Duration.from({ days: 1 });
const endOfZonedDay = startOfZonedDay.add(oneDay);
const endOfDay = endOfZonedDay.toInstant();

Crashes:

const date: Temporal.PlainDate = Temporal.PlainDate.from("2024-03-15");
const startOfDay = date.toZonedDateTime("UTC").toInstant();
const oneDay = Temporal.Duration.from({ days: 1 });
const endOfDay = startOfDay.add(oneDay);

[nulltoken]

See tc39/proposal-temporal#3265

Looks like the behavior is spec compliant (and makes sense). However, maybe a slightly more expressive error message may be worth it from a consumer standpoint?

[arshaw]

Ya, error is happening here:

const endOfDay = startOfDay.add(oneDay);

Reference implementation gives message: "Duration field day not supported by Temporal.Instant. Try Temporal.ZonedDateTime instead."

temporal-polyfill gives message: "Cannot use large units"

Yeah, it could definitely be improved