Fix "memory leak" by closing file objects #580
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SingleHDF5ToZarr class will consume unsightly amounts of memory over extended periods of time. I tracked this memory usage down to the fact that the class does not close the hdf5 file. Adding a
SingleHDF5ToZarr.close()method that closed h5py file and the associated fsspec file object solved the slow leak.This cut memory usage from >1GB to less than 300MB after processing a large number of hdf5 files. The close method can be invoked directly or via a
contextlib.closingcontext.The example
gen_jsonfunction would like the following with these changes to ensure resources are properly cleaned up.