fix(linking): deep-merge link_references from creation and deployed bytecode

[VolodymyrBg]

Before: Dependencies were built by shallow-merging link_references maps via extend. When both creation and deployed bytecode contained references under the same file key but with different library names, the latter overwrote the former, dropping dependencies.

After: We deep-merge the inner maps per file, unioning library names and offsets from both sources. This matches how we link and validate both bytecode objects and aligns with forge inspect ... libraries (union semantics). Prevents missing libs when a file has libraries used exclusively in constructor vs runtime.

[DaniPopes]

Is there a test case we could add for this that would fail before?

@klkvr thoughts?

[VolodymyrBg]

Is there a test case we could add for this that would fail before?

@klkvr thoughts?

Yes, added a test case

[klkvr]

lgtm, left a suggestion for driveby clean up

also need to commit the test files and investigate whether the linking tests are actually testing anything

[klkvr]

needs rebase and ci fixes

[VolodymyrBg]

needs rebase and ci fixes

test / nextest / test unit (x86_64-pc-windows-msvc) (pull_request)
test / nextest / test unit (x86_64-pc-windows-msvc) (pull_request)Failing after 6m
test / nextest / test unit (x86_64-unknown-linux-gnu) (pull_request)
test / nextest / test unit (x86_64-unknown-linux-gnu) (pull_request)Failing after 2m

I'm sorry but i can't fix this, i can't just test it on my computer, it's not that powerful, and I think making noise here is not the best idea..

[DaniPopes]

Thanks! Updated tests. I verified that the added test fails on master and passes in this PR.

addressed

[VolodymyrBg]

Thanks! Updated tests. I verified that the added test fails on master and passes in this PR.

Wow, thank you, too. I didn't really know how to revert my incorrect rebase so i was stuck, thank you for your help