fix(lint): bound reentrancy helper analysis (#15063)

* fix(lint): bound reentrancy helper analysis

* address steven's comments

* fix reentrancy events clippy

* address steven's comments

Author: figtracer

Cargo.lock

@@ -604,10 +604,10 @@ tempo-alloy = { git = "https://github.com/tempoxyz/tempo", rev = "4d3f1db11a496d
 tempo-contracts = { git = "https://github.com/tempoxyz/tempo", rev = "4d3f1db11a496d5fc98bb33d8055de102e5f5e11" }
 
 # solar
-solar = { package = "solar-compiler", git = "https://github.com/paradigmxyz/solar", rev = "4393d0dbb8d37df4df5c2840350a73a189441988" }
-solar-interface = { package = "solar-interface", git = "https://github.com/paradigmxyz/solar", rev = "4393d0dbb8d37df4df5c2840350a73a189441988" }
-solar-ast = { package = "solar-ast", git = "https://github.com/paradigmxyz/solar", rev = "4393d0dbb8d37df4df5c2840350a73a189441988" }
-solar-sema = { package = "solar-sema", git = "https://github.com/paradigmxyz/solar", rev = "4393d0dbb8d37df4df5c2840350a73a189441988" }
+solar = { package = "solar-compiler", git = "https://github.com/paradigmxyz/solar", rev = "da6b0c3a8c0edd23f8b1414c61418ba78d6c4670" }
+solar-interface = { package = "solar-interface", git = "https://github.com/paradigmxyz/solar", rev = "da6b0c3a8c0edd23f8b1414c61418ba78d6c4670" }
+solar-ast = { package = "solar-ast", git = "https://github.com/paradigmxyz/solar", rev = "da6b0c3a8c0edd23f8b1414c61418ba78d6c4670" }
+solar-sema = { package = "solar-sema", git = "https://github.com/paradigmxyz/solar", rev = "da6b0c3a8c0edd23f8b1414c61418ba78d6c4670" }
 
 [workspace.metadata.cargo-shear]
 ignored = ["idna_adapter", "cast", "chisel", "forge", "alloy-contract"]

Cargo.toml

@@ -0,0 +1,62 @@
+use std::{
+    collections::{HashMap, HashSet, VecDeque},
+    hash::Hash,
+};
+
+pub const DEFAULT_HELPER_ANALYSIS_CACHE_LIMIT: usize = 65_536;
+
+/// Bounded memo table for lint analyses that inline internal helper calls.
+#[derive(Debug)]
+pub struct HelperAnalysisCache<K, V> {
+    entries: HashMap<K, V>,
+    in_progress: HashSet<K>,
+    order: VecDeque<K>,
+    max_entries: usize,
+}
+
+impl<K, V> HelperAnalysisCache<K, V>
+where
+    K: Clone + Eq + Hash,
+{
+    pub fn new(max_entries: usize) -> Self {
+        Self {
+            entries: HashMap::new(),
+            in_progress: HashSet::new(),
+            order: VecDeque::new(),
+            max_entries,
+        }
+    }
+
+    pub fn is_in_progress(&self, key: &K) -> bool {
+        self.in_progress.contains(key)
+    }
+
+    pub fn get(&self, key: &K) -> Option<&V> {
+        self.entries.get(key)
+    }
+
+    pub fn start(&mut self, key: K) {
+        self.in_progress.insert(key);
+    }
+
+    pub fn finish(&mut self, key: K, value: V) {
+        self.in_progress.remove(&key);
+        if self.max_entries == 0 {
+            return;
+        }
+
+        if !self.entries.contains_key(&key) {
+            self.order.push_back(key.clone());
+        }
+        self.entries.insert(key, value);
+
+        while self.entries.len() > self.max_entries {
+            if let Some(oldest) = self.order.pop_front() {
+                self.entries.remove(&oldest);
+                self.in_progress.remove(&oldest);
+            } else {
+                break;
+            }
+        }
+    }
+}

crates/lint/src/sol/analysis/helper_cache.rs

@@ -7,5 +7,6 @@
 //!
 //! All helpers borrow HIR and never mutate it.
 
+pub mod helper_cache;
 pub mod interface;
 pub mod primitives;