Merge pull request #472 from fortran-lang/fix/diag-error-lowercase-interface-args

fix: diagnostic error for interface arguments

Author: gnikit

fortls/parsers/internal/subroutine.py

@@ -86,7 +86,7 @@ def resolve_arg_link(self, obj_tree):
                 # block's children i.e. functions and subroutines to see if one matches
                 elif child.name.lower().startswith("#gen_int"):
                     for sub_child in child.children:
-                        if arg == sub_child.name:
+                        if arg == sub_child.name.lower():
                             self.arg_objs[i] = sub_child
                             break
 

test/test_server_diagnostics.py

@@ -440,3 +440,18 @@ def test_critical_scope():
     errcode, results = run_request(string, ["-n", "1"])
     assert errcode == 0
     assert results[1]["diagnostics"] == []
+
+
+def test_mixed_case_interface_sub_child():
+    """
+    Test that interface sub_child arguments are correctly resolved
+    regardless of their case.
+    """
+    string = write_rpc_request(1, "initialize", {"rootPath": str(test_dir / "diag")})
+    file_path = str(test_dir / "diag" / "mixed_case_interface_sub_child.f90")
+    string += write_rpc_notification(
+        "textDocument/didOpen", {"textDocument": {"uri": file_path}}
+    )
+    errcode, results = run_request(string, ["-n", "1"])
+    assert errcode == 0
+    assert results[1]["diagnostics"] == []

test/test_source/diag/test_mixed_case_interface_sub_child.f90

@@ -0,0 +1,11 @@
+module mixed_case_interface_sub_child
+  implicit none
+
+contains
+  subroutine foo(Func)
+    interface
+      function Func()
+      end function Func
+    end interface
+  end subroutine foo
+end module mixed_case_interface_sub_child