Skip to content

Commit ff5b514

Browse files
chore(internal): support x-stainless-mcp-client-envs header in MCP servers
1 parent a23cc61 commit ff5b514

4 files changed

Lines changed: 43 additions & 15 deletions

File tree

packages/mcp-server/src/code-tool.ts

Lines changed: 25 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -142,19 +142,23 @@ const remoteStainlessHandler = async ({
142142

143143
const codeModeEndpoint = readEnv('CODE_MODE_ENDPOINT_URL') ?? 'https://api.stainless.com/api/ai/code-tool';
144144

145+
const localClientEnvs = {
146+
HUB_API_KEY: requireValue(
147+
readEnv('HUB_API_KEY') ?? client.apiKey,
148+
'set HUB_API_KEY environment variable or provide apiKey client option',
149+
),
150+
FORMBRICKS_HUB_BASE_URL: readEnv('FORMBRICKS_HUB_BASE_URL') ?? client.baseURL ?? undefined,
151+
};
152+
// Merge any upstream client envs from the request header, with upstream values taking precedence.
153+
const mergedClientEnvs = { ...localClientEnvs, ...reqContext.upstreamClientEnvs };
154+
145155
// Setting a Stainless API key authenticates requests to the code tool endpoint.
146156
const res = await fetch(codeModeEndpoint, {
147157
method: 'POST',
148158
headers: {
149159
...(reqContext.stainlessApiKey && { Authorization: reqContext.stainlessApiKey }),
150160
'Content-Type': 'application/json',
151-
'x-stainless-mcp-client-envs': JSON.stringify({
152-
HUB_API_KEY: requireValue(
153-
readEnv('HUB_API_KEY') ?? client.apiKey,
154-
'set HUB_API_KEY environment variable or provide apiKey client option',
155-
),
156-
FORMBRICKS_HUB_BASE_URL: readEnv('FORMBRICKS_HUB_BASE_URL') ?? client.baseURL ?? undefined,
157-
}),
161+
'x-stainless-mcp-client-envs': JSON.stringify(mergedClientEnvs),
158162
},
159163
body: JSON.stringify({
160164
project_name: 'hub',
@@ -265,6 +269,9 @@ const localDenoHandler = async ({
265269
printOutput: true,
266270
spawnOptions: {
267271
cwd: path.dirname(workerPath),
272+
// Merge any upstream client envs into the Deno subprocess environment,
273+
// with the upstream env vars taking precedence.
274+
env: { ...process.env, ...reqContext.upstreamClientEnvs },
268275
},
269276
});
270277

@@ -274,13 +281,17 @@ const localDenoHandler = async ({
274281
reject(new Error(`Worker exited with code ${exitCode}`));
275282
});
276283

277-
const opts: ClientOptions = {
278-
baseURL: client.baseURL,
279-
apiKey: client.apiKey,
280-
defaultHeaders: {
281-
'X-Stainless-MCP': 'true',
282-
},
283-
};
284+
// Strip null/undefined values so that the worker SDK client can fall back to
285+
// reading from environment variables (including any upstreamClientEnvs).
286+
const opts: ClientOptions = Object.fromEntries(
287+
Object.entries({
288+
baseURL: client.baseURL,
289+
apiKey: client.apiKey,
290+
defaultHeaders: {
291+
'X-Stainless-MCP': 'true',
292+
},
293+
}).filter(([_, v]) => v != null),
294+
) as ClientOptions;
284295

285296
const req = worker.request(
286297
'http://localhost',

packages/mcp-server/src/http.ts

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,19 @@ const newServer = async ({
2727

2828
const authOptions = parseClientAuthHeaders(req, false);
2929

30+
let upstreamClientEnvs: Record<string, string> | undefined;
31+
const clientEnvsHeader = req.headers['x-stainless-mcp-client-envs'];
32+
if (typeof clientEnvsHeader === 'string') {
33+
try {
34+
const parsed = JSON.parse(clientEnvsHeader);
35+
if (parsed && typeof parsed === 'object' && !Array.isArray(parsed)) {
36+
upstreamClientEnvs = parsed;
37+
}
38+
} catch {
39+
// Ignore malformed header
40+
}
41+
}
42+
3043
await initMcpServer({
3144
server: server,
3245
mcpOptions: mcpOptions,
@@ -35,6 +48,7 @@ const newServer = async ({
3548
...authOptions,
3649
},
3750
stainlessApiKey: stainlessApiKey,
51+
upstreamClientEnvs,
3852
});
3953

4054
return server;
@@ -72,7 +86,7 @@ const del = async (req: express.Request, res: express.Response) => {
7286
};
7387

7488
const redactHeaders = (headers: Record<string, any>) => {
75-
const hiddenHeaders = /auth|cookie|key|token/i;
89+
const hiddenHeaders = /auth|cookie|key|token|x-stainless-mcp-client-envs/i;
7690
const filtered = { ...headers };
7791
Object.keys(filtered).forEach((key) => {
7892
if (hiddenHeaders.test(key)) {

packages/mcp-server/src/server.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ export async function initMcpServer(params: {
3737
clientOptions?: ClientOptions;
3838
mcpOptions?: McpOptions;
3939
stainlessApiKey?: string | undefined;
40+
upstreamClientEnvs?: Record<string, string> | undefined;
4041
}) {
4142
const server = params.server instanceof McpServer ? params.server.server : params.server;
4243

@@ -118,6 +119,7 @@ export async function initMcpServer(params: {
118119
reqContext: {
119120
client,
120121
stainlessApiKey: params.stainlessApiKey ?? params.mcpOptions?.stainlessApiKey,
122+
upstreamClientEnvs: params.upstreamClientEnvs,
121123
},
122124
args,
123125
});

packages/mcp-server/src/types.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ export type ToolCallResult = {
4545
export type McpRequestContext = {
4646
client: FormbricksHub;
4747
stainlessApiKey?: string | undefined;
48+
upstreamClientEnvs?: Record<string, string> | undefined;
4849
};
4950

5051
export type HandlerFunction = ({

0 commit comments

Comments
 (0)