Skip to content

Commit 944fde4

Browse files
flyingrobotsclaude
andcommitted
docs(changelog): add CodeRabbitAI review fixes section (PR #260)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent ef17adb commit 944fde4

1 file changed

Lines changed: 13 additions & 0 deletions

File tree

CHANGELOG.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,19 @@
7272
- Deleted `sharded_equals_stride` and `sharded_equals_stride_permuted` tests (no longer needed post-transition)
7373
- **Deprecated `emit_view_op_delta()`** (`rules.rs`): Deleted non-deterministic function that used `delta.len()` sequencing
7474

75+
### Fixed - CodeRabbitAI Review (PR #260)
76+
77+
- **P0: Off-by-one in `publish_truth`** (`playback.rs`): Query `prov_tick = cursor.tick - 1` (0-based index of last applied patch) instead of `cursor.tick`; added early-return guard for `cursor.tick == 0`
78+
- **P0: Wrong package in bench docs** (`docs/notes/boaw-perf-baseline.md`): Corrected `warp-core``warp-benches`
79+
- **P1: Dead variant removal** (`playback.rs`): Removed `SeekError::CommitHashMismatch` (never constructed) and `SeekThen::RestorePrevious` (broken semantics)
80+
- **P1: OOM prevention** (`materialization/frame_v2.rs`): Bound `entry_count` by remaining payload size in `decode_v2_packet` to prevent malicious allocation
81+
- **P1: Fork guard** (`provenance_store.rs`): Added `WorldlineAlreadyExists` error variant; `fork()` rejects duplicate worldline IDs
82+
- **P1: Dangling edge validation** (`worldline.rs`): `UpsertEdge` now verifies `from`/`to` nodes exist in store before applying
83+
- **P1: Silent skip → panic** (`boaw/exec.rs`): Replaced `debug_assert!` + `continue` with `.expect()` for missing view resolution
84+
- **P2: Tilde-pin bytes dep** (`crates/warp-benches/Cargo.toml`): `bytes = "~1.11"` for minor-version stability
85+
- **P2: Markdownlint rationale** (`.markdownlint.json`): Added `rationale` key for MD060 rule
86+
- **P2: Test hardening** (`tests/`): Added u8 truncation guards (`num_ticks <= 127`), `commit_hash` assertion, updated playback tests to match corrected `publish_truth` indexing
87+
7588
### Fixed - PR #257 Review
7689

7790
- **pre-commit hook**: Preserve stderr in prettier checks (changed `>/dev/null 2>&1` to `>/dev/null`) so errors are visible

0 commit comments

Comments
 (0)