Skip to content

Commit 4c4bb72

Browse files
flyingrobotsclaude
andcommitted
fix(docs): rustdoc link + determinism allowlist for ECHO_WORKERS
- Change intra-doc links to private `default_worker_count()` to plain code - Add engine_impl.rs to ban-nondeterminism-allowlist (ECHO_WORKERS is config) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent e245560 commit 4c4bb72

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

.ban-nondeterminism-allowlist

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,3 +8,7 @@ crates/warp-core/src/wsc/view.rs
88
# BOAW exec uses std::env for feature-gated stride fallback (ECHO_PARALLEL_STRIDE)
99
# This is a build-time debug toggle, not runtime non-determinism
1010
crates/warp-core/src/boaw/exec.rs
11+
# engine_impl uses std::env for ECHO_WORKERS configuration
12+
# This is read once at engine construction for worker count - determinism is not affected
13+
# because the worker count doesn't change execution results, only parallelism level
14+
crates/warp-core/src/engine_impl.rs

crates/warp-core/src/engine_impl.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ impl EngineBuilder<FreshStore> {
197197
/// Defaults:
198198
/// - Scheduler: [`SchedulerKind::Radix`]
199199
/// - Policy ID: [`crate::POLICY_ID_NO_POLICY_V0`]
200-
/// - Worker count: [`default_worker_count()`] (env `ECHO_WORKERS` or `available_parallelism`)
200+
/// - Worker count: `default_worker_count()` (env `ECHO_WORKERS` or `available_parallelism`)
201201
/// - Telemetry: [`NullTelemetrySink`]
202202
/// - `MaterializationBus`: A fresh bus with no pre-registered channels
203203
pub fn new(store: GraphStore, root: NodeId) -> Self {
@@ -236,7 +236,7 @@ impl EngineBuilder<ExistingState> {
236236
/// Defaults:
237237
/// - Scheduler: [`SchedulerKind::Radix`]
238238
/// - Policy ID: [`crate::POLICY_ID_NO_POLICY_V0`]
239-
/// - Worker count: [`default_worker_count()`] (env `ECHO_WORKERS` or `available_parallelism`)
239+
/// - Worker count: `default_worker_count()` (env `ECHO_WORKERS` or `available_parallelism`)
240240
/// - Telemetry: [`NullTelemetrySink`]
241241
/// - `MaterializationBus`: A fresh bus with no pre-registered channels
242242
pub fn from_state(state: WarpState, root: NodeKey) -> Self {
@@ -292,7 +292,7 @@ impl<S> EngineBuilder<S> {
292292

293293
/// Sets the worker count for parallel execution.
294294
///
295-
/// Default: [`default_worker_count()`] (env `ECHO_WORKERS` or `available_parallelism`).
295+
/// Default: `default_worker_count()` (env `ECHO_WORKERS` or `available_parallelism`).
296296
///
297297
/// # Notes
298298
///

0 commit comments

Comments
 (0)