ValuesFrom optional field not working for a particular key

[tanujd11]

While using ValuesFrom from configmap and keeping optional: true as config, it is showing the following error:

missing key '' in ConfigMap ''

Is this expected behaviour, I am using same configmap for multiple keys. I think the optional field is working only when the configmap is not present altogether. Instead if configmap is present and the key is also not present, the optional field should be respected.

I am talking about the following piece of code

helm-controller/controllers/helmrelease_controller.go

Lines 544 to 548 in 6f0b7cd

	if data, ok := resource.Data[v.GetValuesKey()]; !ok {
	return nil, fmt.Errorf("missing key '%s' in %s '%s'", v.GetValuesKey(), v.Kind, namespacedName)
	} else {
	valuesData = []byte(data)
	}

Why is the optional not handled in this case?

[tanujd11]

@hiddeco @stefanprodan can you help out here? I would be happy to raise the PR, if this is how it should be. Thanks

[tanujd11]

#589

[hiddeco]

This is by design, as described in the commit which introduced this (and in the documentation of the field itself): 1a88b40. In my opinion, this results in a better feedback loop in case a field is accidentally deleted which could otherwise go unnoticed.

[tanujd11]

Hey @hiddeco my usecase is that, I would want to render this in GitOps rep but if this field is not present it will take the default value, but this error fails it.