Skip to content

Conversation

@vashworth
Copy link
Contributor

Redistribute iOS CODEOWNERS to rebalance load between team.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request redistributes ownership for several iOS packages in the CODEOWNERS file to rebalance the workload. My review focuses on improving the formatting and maintainability of this file. I've suggested aligning the owners and sorting them alphabetically for better readability.

Comment on lines +87 to +103
packages/camera/camera_avfoundation/** @hellohuanlin @louisehsu
packages/file_selector/file_selector_ios/** @okorohelijah @vashworth
packages/file_selector/file_selector_macos/** @okorohelijah @vashworth
packages/google_maps_flutter/google_maps_flutter_ios/** @vashworth @LongCatIsLooong
packages/google_sign_in/google_sign_in_ios/** @LongCatIsLooong @okorohelijah
packages/image_picker/image_picker_ios/** @okorohelijah @vashworth
packages/image_picker/image_picker_macos/** @okorohelijah @vashworth
packages/in_app_purchase/in_app_purchase_storekit/** @louisehsu @LongCatIsLooong
packages/local_auth/local_auth_darwin/** @vashworth @okorohelijah
packages/path_provider/path_provider_foundation/** @vashworth
packages/local_auth/local_auth_darwin/** @louisehsu @okorohelijah
packages/path_provider/path_provider_foundation/** @LongCatIsLooong @vashworth
packages/pointer_interceptor/pointer_interceptor_ios/** @louisehsu @hellohuanlin
packages/quick_actions/quick_actions_ios/** @LongCatIsLooong @hellohuanlin
packages/quick_actions/quick_actions_ios/** @louisehsu @LongCatIsLooong
packages/shared_preferences/shared_preferences_foundation/** @tarrinneal
packages/url_launcher/url_launcher_ios/** @hellohuanlin @LongCatIsLooong
packages/url_launcher/url_launcher_macos/** @hellohuanlin @LongCatIsLooong
packages/video_player/video_player_avfoundation/** @LongCatIsLooong @hellohuanlin
packages/webview_flutter/webview_flutter_wkwebview/** @louisehsu
packages/url_launcher/url_launcher_ios/** @vashworth @LongCatIsLooong
packages/url_launcher/url_launcher_macos/** @vashworth @LongCatIsLooong
packages/video_player/video_player_avfoundation/** @hellohuanlin @louisehsu
packages/webview_flutter/webview_flutter_wkwebview/** @LongCatIsLooong @hellohuanlin

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability and maintainability, it's good practice to keep the CODEOWNERS file well-formatted.

I'd suggest two improvements for the Darwin section:

  1. Align all owner handles to the same column.
  2. Sort owner handles alphabetically (case-insensitively) on each line.

This makes the file easier to read and maintain.

packages/camera/camera_avfoundation/**                      @hellohuanlin @louisehsu
packages/file_selector/file_selector_ios/**                 @okorohelijah @vashworth
packages/file_selector/file_selector_macos/**               @okorohelijah @vashworth
packages/google_maps_flutter/google_maps_flutter_ios/**     @LongCatIsLooong @vashworth
packages/google_sign_in/google_sign_in_ios/**               @LongCatIsLooong @okorohelijah
packages/image_picker/image_picker_ios/**                   @okorohelijah @vashworth
packages/image_picker/image_picker_macos/**                 @okorohelijah @vashworth
packages/in_app_purchase/in_app_purchase_storekit/**        @LongCatIsLooong @louisehsu
packages/local_auth/local_auth_darwin/**                    @louisehsu @okorohelijah
packages/path_provider/path_provider_foundation/**          @LongCatIsLooong @vashworth
packages/pointer_interceptor/pointer_interceptor_ios/**     @hellohuanlin @louisehsu
packages/quick_actions/quick_actions_ios/**                 @LongCatIsLooong @louisehsu
packages/shared_preferences/shared_preferences_foundation/** @tarrinneal
packages/url_launcher/url_launcher_ios/**                   @LongCatIsLooong @vashworth
packages/url_launcher/url_launcher_macos/**                 @LongCatIsLooong @vashworth
packages/video_player/video_player_avfoundation/**          @hellohuanlin @louisehsu
packages/webview_flutter/webview_flutter_wkwebview/**       @hellohuanlin @LongCatIsLooong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants