Skip to content

Commit edaa93f

Browse files
committed
fix(interfaces): add XMLHttpRequest to AxiosError#request definition
- https://axios-http.com/docs/res_schema Signed-off-by: Lexus Drumgold <[email protected]>
1 parent 956dd03 commit edaa93f

File tree

5 files changed

+5
-5
lines changed

5 files changed

+5
-5
lines changed

__fixtures__/error-axios-404.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,6 @@ export default createError(
2020
'Request failed with status code 404',
2121
RESPONSE.config,
2222
undefined,
23-
{} as unknown as ClientRequest,
23+
{} as ClientRequest | XMLHttpRequest,
2424
RESPONSE
2525
) as AxiosErrorType

__fixtures__/error-axios-no-res.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@ export default createError(
1313
'Request failed with status code 500',
1414
config,
1515
'ECONNABORTED',
16-
{} as unknown as ClientRequest
16+
{} as ClientRequest | XMLHttpRequest
1717
)

src/interfaces/axios-error.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ interface AxiosError<Payload = any, Data = any> extends Error {
2121
readonly code?: string
2222
readonly config: AxiosRequestConfig<Data>
2323
readonly isAxiosError: boolean
24-
readonly request?: ClientRequest
24+
readonly request?: ClientRequest | XMLHttpRequest
2525
readonly response?: AxiosResponse<Payload, Data>
2626
toJSON(): AxiosErrorJSON<Data>
2727
}

tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"experimentalDecorators": true,
1616
"forceConsistentCasingInFileNames": true,
1717
"isolatedModules": false,
18-
"lib": ["es2021"],
18+
"lib": ["dom", "es2021"],
1919
"module": "esnext",
2020
"moduleResolution": "node",
2121
"newLine": "lf",

typings/axios/lib/core/createError.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ declare module 'axios/lib/core/createError' {
77
message: string,
88
config: AxiosRequestConfig<Data>,
99
code?: string,
10-
request?: ClientRequest,
10+
request?: ClientRequest | XMLHttpRequest,
1111
response?: AxiosResponse<Payload, Data>
1212
): AxiosError<Payload, Data>
1313
}

0 commit comments

Comments
 (0)