builder-manifest: Prevent writing duplicate groups to metadata file #679
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A locale or debug extension group may already be written by `builder_extension_add_finish_args()` if the user specified them via `add-extensions` or similar manifest properties. In this case, we should not attempt to write our automatic extension groups again. These extensions should either be user supplied or the user should let flatpak-builder handle them, not both at the same time. Fixes one issue in #618
|
Maybe it'd be a side quest to port the writing here to use |
swick
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A locale or debug extension group may already be written by
builder_extension_add_finish_args()if the user specified them viaadd-extensionsor similar manifest properties. In this case, we should not attempt to write our automatic extension groups again. These extensions should either be user supplied or the user should let flatpak-builder handle them, not both at the same time.Fixes one issue in #618