chore: show slotTime in millis #212
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amliu-jumptrading
changed the base branch from
amliu/navigation1
to
amliu/navigation3
asuzuki-jumptrading
approved these changes
Dec 5, 2025
Comment on lines
41
to
55
| const formattedParts = formatter.formatToParts(date); | ||
| const zeroPrefixedNanos = remainderNanos.toString().padStart(6, "0"); | ||
|
|
||
| let inMillis = ""; | ||
| let inNanos = ""; | ||
|
|
||
| for (const part of formattedParts) { | ||
| inMillis += part.value; | ||
| inNanos += part.value; | ||
| if (part.type === "fractionalSecond") { | ||
| inNanos += zeroPrefixedNanos; | ||
| } | ||
| } | ||
|
|
||
| return { inMillis, inNanos }; |
Collaborator
There was a problem hiding this comment.
Could we add a test for this part?
Just to make sure we catch if the formatter type value changes or something
amliu-jumptrading
force-pushed
the
slottime
branch
from
1e631a6 to
e150e1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.