wrap unresolved flake in ifdef

paulb777 · paulb777 · commit db323110b357 · 2025-11-28T09:28:31.000-08:00
diff --git a/Crashlytics/UnitTests/FIRCLSSettingsTests.m b/Crashlytics/UnitTests/FIRCLSSettingsTests.m
@@ -326,6 +326,7 @@ - (void)testGoogleAppIDChanged {
   XCTAssertEqual(self.settings.errorLogBufferSize, 64 * 1000);
 }
 
+#ifdef FLAKY_TEST
 // This is a weird case where we got settings, but never created a cache key for it. We are
 // treating this as if the cache was invalid and re-fetching in this case.
 - (void)testActivatedSettingsMissingCacheKey {
@@ -357,6 +358,7 @@ - (void)testActivatedSettingsMissingCacheKey {
   XCTAssertEqual(self.settings.onDemandBackoffBase, 1.5);
   XCTAssertEqual(self.settings.onDemandBackoffStepDuration, 6);
 }
+#endif  // FLAKY_TEST
 
 // These tests are partially to make sure the SDK doesn't crash when it
 // has corrupted settings.

Original file line number	Diff line number	Diff line change
`@@ -326,6 +326,7 @@ - (void)testGoogleAppIDChanged {`
`326`	`326`	`XCTAssertEqual(self.settings.errorLogBufferSize, 64 * 1000);`
`327`	`327`	`}`
`328`	`328`
	`329`	`+#ifdef FLAKY_TEST`
`329`	`330`	`// This is a weird case where we got settings, but never created a cache key for it. We are`
`330`	`331`	`// treating this as if the cache was invalid and re-fetching in this case.`
`331`	`332`	`- (void)testActivatedSettingsMissingCacheKey {`
`@@ -357,6 +358,7 @@ - (void)testActivatedSettingsMissingCacheKey {`
`357`	`358`	`XCTAssertEqual(self.settings.onDemandBackoffBase, 1.5);`
`358`	`359`	`XCTAssertEqual(self.settings.onDemandBackoffStepDuration, 6);`
`359`	`360`	`}`
	`361`	`+#endif // FLAKY_TEST`
`360`	`362`
`361`	`363`	`// These tests are partially to make sure the SDK doesn't crash when it`
`362`	`364`	`// has corrupted settings.`