Make horizontal padding configurable on IconCollectionView (#1421)

* Pass padding

* Test spacing between image and text

* Remove unnecessary code

* Update FinniversKit/Sources/Components/IconCollection/IconCollectionView.swift

Co-authored-by: Andrii <[email protected]>

* Update FinniversKit/Sources/Components/IconCollection/IconCollectionView.swift

Co-authored-by: Andrii <[email protected]>

---------

Co-authored-by: Andrii <[email protected]>

Author: marianaSchibsted

FinniversKit/Sources/Components/IconCollection/HorizontalIconCollectionViewCell.swift

@@ -6,13 +6,18 @@ import UIKit
 import Warp
 
 public class HorizontalIconCollectionViewCell: UICollectionViewCell {
-    private static let titleSideMargin = Warp.Spacing.spacing100
+    private static let leadingInset: CGFloat = 0
+    private static let trailingInset: CGFloat = Warp.Spacing.spacing100
+    private static let iconToTextSpacing: CGFloat = Warp.Spacing.spacing100
+    private static let verticalPadding: CGFloat = Warp.Spacing.spacing50
     private static let titleStyle = Warp.Typography.body
     private static let bodyStyle = Warp.Typography.bodyStrong
 
     static func height(for viewModel: IconCollectionViewModel, withWidth width: CGFloat) -> CGFloat {
         let imageSize = viewModel.image.size
-        let textWidth = width - imageSize.width - (3 * titleSideMargin)
+        let textWidth = width
+                    - imageSize.width
+                    - (Self.leadingInset + Self.iconToTextSpacing + Self.trailingInset)
 
         let titleHeight = viewModel.title?.height(withConstrainedWidth: textWidth, font: titleStyle.uiFont) ?? 0
         let bodyHeight = viewModel.text.height(withConstrainedWidth: textWidth, font: bodyStyle.uiFont)
@@ -87,15 +92,17 @@ public class HorizontalIconCollectionViewCell: UICollectionViewCell {
 
         NSLayoutConstraint.activate([
             iconImageView.centerYAnchor.constraint(equalTo: contentView.centerYAnchor),
-            iconImageView.leadingAnchor.constraint(equalTo: contentView.leadingAnchor, constant: HorizontalIconCollectionViewCell.titleSideMargin),
+            iconImageView.leadingAnchor.constraint(equalTo: contentView.leadingAnchor, constant: Self.leadingInset),
 
-            titleLabel.topAnchor.constraint(equalTo: contentView.topAnchor, constant: Warp.Spacing.spacing50),
-            titleLabel.leadingAnchor.constraint(equalTo: iconImageView.trailingAnchor, constant: HorizontalIconCollectionViewCell.titleSideMargin),
-            titleLabel.trailingAnchor.constraint(equalTo: contentView.trailingAnchor, constant: -HorizontalIconCollectionViewCell.titleSideMargin),
+            titleLabel.topAnchor.constraint(equalTo: contentView.topAnchor, constant: Self.verticalPadding),
+            titleLabel.leadingAnchor.constraint(equalTo: iconImageView.trailingAnchor, constant: Self.iconToTextSpacing),
+            titleLabel.trailingAnchor.constraint(equalTo: contentView.trailingAnchor, constant: -Self.trailingInset),
 
             bodyLabel.topAnchor.constraint(equalTo: titleLabel.bottomAnchor),
-            bodyLabel.leadingAnchor.constraint(equalTo: iconImageView.trailingAnchor, constant: HorizontalIconCollectionViewCell.titleSideMargin),
-            bodyLabel.trailingAnchor.constraint(equalTo: contentView.trailingAnchor, constant: -HorizontalIconCollectionViewCell.titleSideMargin)
+            bodyLabel.leadingAnchor.constraint(equalTo: iconImageView.trailingAnchor, constant: Self.iconToTextSpacing),
+            bodyLabel.trailingAnchor.constraint(equalTo: contentView.trailingAnchor, constant: -Self.trailingInset),
+
+            bodyLabel.bottomAnchor.constraint(lessThanOrEqualTo: contentView.bottomAnchor, constant: -Self.verticalPadding)
         ])
     }
 }

FinniversKit/Sources/Components/IconCollection/IconCollectionView.swift

@@ -20,7 +20,8 @@ public final class IconCollectionView: UIView {
 
     // MARK: - Private properties
 
-    private var alignment: Alignment
+    private let alignment: Alignment
+    private let horisontalPadding: CGFloat
     private var viewModels = [IconCollectionViewModel]()
 
     private lazy var collectionView: UICollectionView = {
@@ -46,16 +47,17 @@ public final class IconCollectionView: UIView {
     private lazy var margins: UIEdgeInsets = {
         switch alignment {
         case .horizontal:
-            return UIEdgeInsets(vertical: Warp.Spacing.spacing200, horizontal: Warp.Spacing.spacing50)
+            return UIEdgeInsets(vertical: Warp.Spacing.spacing200, horizontal: horisontalPadding)
         case .vertical:
             return .zero
         }
     }()
 
     // MARK: - Init
 
-    public init(alignment: Alignment = .vertical) {
+    public init(alignment: Alignment = .vertical, horisontalPadding: CGFloat = Warp.Spacing.spacing50) {
         self.alignment = alignment
+        self.horisontalPadding = horisontalPadding
         super.init(frame: .zero)
         setup()
     }