Checker case list

[that-hatter]

A list of cases that will be covered by the new script checker in the works, i.e. mistakes that will not be caught by loading the script (and the utility scripts) and calling its .initial_effect function. Test files for each case (or subcase) will be added as a task, and will be marked finished once that file is correctly handled.

Errors

Non-existent functions

Should error when trying to call a function that is not defined.

• nonexistent-function-1.lua

Mismatched arguments

Should error when the type of the argument(s) being passed to a function doesn't match its parameters.

• argument-type-mismatch-1.lua

Condition function signature inference

Infer the signature of a condition function based on what was passed to the corresponding SetType call in its parent Effect, and check the types in the function body against the inferred types.

• condition-function-signature-inference.lua

Filter function signature inference

Infer the signature of a filter function based on what was passed as extra arguments to the function that used that filter (e.g. Duel.IsExistingMatchingCard), and check the types in the function body against the inferred types.

• filter-function-signature-inference.lua

Pseudo-enums

When calling certain functions, allow only certain constants (or combination of those constants) to be passed (e.g. allow only LOCATION_ constants for SetRange, and only CATEGORY_ constants for SetCategory). Magic numbers should be disallowed as well.

Global constant reassignment

Should error when a global constant is being assigned a new value.

Style Enforcement

Non-UPPER_CASE global constants

Using + for bitfield/bitmask values

Calling with omitted parentheses

Redundant ternary trick

[pyrQ]

A couple of ideas:

• Declared but unused functions (the inverse of "Non-existent functions"), like a misnamed function or a leftover and now unused filter function. For example, the condition of an If you control a Warrior monster: .. effect:

function s.confilter(c)
	return c:IsRace(RACE_WARRIOR) and c:IsFaceup()
end
function s.spcon(e,tp,eg,ep,ev,re,r,rp)
	--"s.confilter" was used here previously
	return Duel.IsExistingMatchingCard(aux.FaceupFilter(Card.IsRace,RACE_WARRIOR),tp,LOCATION_MZONE,0,1,nil)
end

• Typos in common table names, e.g. using s.listed_name instead of s.listed_names.