Skip to content

Provide less cryptic error for missing systemlib sections #9566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mszabo-wikia wants to merge 1 commit into from
Closed

Provide less cryptic error for missing systemlib sections #9566

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions hphp/runtime/vm/runtime-compiler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
#include "hphp/zend/zend-string.h"
#include "unit-emitter.h"

#include <stdexcept>
#include <folly/Likely.h>
#include <folly/Range.h>

Expand Down Expand Up @@ -259,6 +260,10 @@ Unit* get_systemlib(const std::string& path, const Extension* extension) {

auto buffer = get_embedded_section(path+".ue");

if (buffer.empty()) {
throw std::invalid_argument("Missing systemlib unit emitter for path: " + path);
}

UnitEmitterSerdeWrapper uew;
BlobDecoder decoder(buffer.data(), buffer.size());
uew.serde(decoder, extension);
Expand Down
Loading