add create email now fixing tests

Author: eugenefvdm

README.md

@@ -124,6 +124,7 @@ Whm::disableEmail('cPanel_username','[email protected]');
 Whm::enableEmail('cPanel_username','[email protected]');
 $whitelist = Whm::cphulkWhitelist();
 $blacklist = Whm::cphulkBlacklist();
+Whm::createEmail('[email protected]');
 
 Whmcs::createClientGroup($name, $colour = '#ffffff');
 Whmcs::createCustomClientField($name, $type = 'text');

src/Contracts/WhmInterface.php

@@ -6,5 +6,16 @@ interface WhmInterface
 {   
     public function bandwidth(): array; 
     public function suspendEmail(string $username, string $email): array;
-    public function unsuspendEmail(string $username, string $email): array;    
+    public function unsuspendEmail(string $username, string $email): array;
+    public function cphulkBlacklist(): array;
+    public function cphulkWhitelist(): array;
+    public function createEmail(
+        string $cpanelUsername,
+        string $email,
+        string $password,
+        ?string $domain = null,
+        ?int $quota = null,
+        bool $sendWelcomeEmail = false
+    ): array;
+    public static function generatePassword(): string;
 }

src/Whm.php

@@ -5,6 +5,7 @@
 use Eugenefvdm\Api\Contracts\WhmInterface;
 use Illuminate\Http\Client\PendingRequest;
 use Illuminate\Support\Facades\Http;
+use Illuminate\Support\Str;
 
 class Whm implements WhmInterface
 {
@@ -105,7 +106,7 @@ public function suspendEmail(string $cpanelUsername, string $email): array
 
     /**
      * Unsuspend an email account's login ability
-     * @link https://api.docs.cpanel.net/openapi/cpanel/operation/suspend_login/
+     * @link https://api.docs.cpanel.net/openapi/cpanel/operation/unsuspend_login/
      * @param string $email The email address to unsuspend
      * @param string $cpanelUsername The cPanel username that owns the email account
      * @return array Response from the API with HTTP status code
@@ -176,6 +177,70 @@ public function cphulkWhitelist(): array
         return $this->client()->get('/json-api/read_cphulk_records?api.version=1&list_name=white')->json();
     }
 
+    /**
+     * Create a new email account
+     * @link https://api.docs.cpanel.net/openapi/cpanel/operation/add_pop/ WHM API Documentation for add_pop
+     * @param string $cpanelUsername The cPanel username that owns the email account
+     * @param string $email The email account username (without domain)
+     * @param string $password The email account password
+     * @param string|null $domain The domain for the email account (defaults to account's main domain)
+     * @param int|null $quota The maximum disk space in MB (0 for unlimited)
+     * @param bool $sendWelcomeEmail Whether to send client configuration instructions
+     * @return array Response from the API with HTTP status code
+     */
+    public function createEmail(
+        string $cpanelUsername,
+        string $email,
+        string $password,
+        ?string $domain = null,
+        ?int $quota = null,
+        bool $sendWelcomeEmail = false
+    ): array {
+        $params = [
+            'cpanel_jsonapi_apiversion' => 3,
+            'cpanel_jsonapi_user' => $cpanelUsername,
+            'cpanel_jsonapi_module' => 'Email',
+            'cpanel_jsonapi_func' => 'add_pop',
+            'email' => $email,
+            'password' => $password,
+        ];
+
+        if ($domain !== null) {
+            $params['domain'] = $domain;
+        }
+
+        if ($quota !== null) {
+            $params['quota'] = $quota;
+        }
+
+        if ($sendWelcomeEmail) {
+            $params['send_welcome_email'] = 1;
+        }
+
+        $response = $this->client()->get('/json-api/cpanel', $params)->json();
+
+        // Check for errors
+        if (isset($response['result']['errors'])) {
+            return [
+                'status' => 'error',
+                'code' => 400,
+                'output' => $response['result']['errors'][0] ?? 'Unknown error occurred'
+            ];
+        }
+
+        // Success case
+        return [
+            'status' => 'success',
+            'code' => 200,
+            'output' => $response['result']['data'] ?? [],
+        ];
+    }
+
+    public static function generatePassword(): string
+    {
+        return Str::random(12);
+    }
+
     /**
      * Set the HTTP client (used for testing)
      *

tests/Feature/WhmTest.php

@@ -108,3 +108,52 @@
     expect($result['data']['ips_in_list'])->toHaveKey('1.2.3.4');
     expect($result['data']['ips_in_list'])->toHaveKey('4.5.106.198');
 });
+
+test('it can create an email account successfully', function () {
+    $whm = mock(WhmInterface::class);
+    
+    $whm->shouldReceive('createEmail')
+        ->with('username', 'user', 'password123', null, null, false)
+        ->andReturn(json_decode(file_get_contents(__DIR__.'/../stubs/whm/create_email_success.json'), true));
+
+    $result = $whm->createEmail('username', 'user', 'password123');
+
+    expect($result['status'])->toBe('success');
+    expect($result['code'])->toBe(200);
+    expect($result['output'])->toBe('user+example.com');
+})->only();
+
+test('it returns 400 when email account already exists', function () {
+    $whm = mock(WhmInterface::class);
+    
+    $whm->shouldReceive('createEmail')
+        ->with('username', 'user', 'password123', null, null, false)
+        ->andReturn(json_decode(file_get_contents(__DIR__.'/../stubs/whm/create_email_already_exists.json'), true));
+
+    $result = $whm->createEmail('username', 'user', 'password123');
+
+    expect($result['status'])->toBe('error');
+    expect($result['code'])->toBe(400);
+    expect($result['output'])->toBe('The account [email protected] already exists!');
+});
+
+test('it returns 400 when password strength is too weak', function () {
+    $whm = mock(WhmInterface::class);
+    
+    $whm->shouldReceive('createEmail')
+        ->with('username', 'user', 'weakpass', null, null, false)
+        ->andReturn(json_decode(file_get_contents(__DIR__.'/../stubs/whm/create_email_password_strengh_issue.json'), true));
+
+    $result = $whm->createEmail('username', 'user', 'weakpass');
+
+    expect($result['status'])->toBe('error');
+    expect($result['code'])->toBe(400);
+    expect($result['output'])->toBe('The password that you entered has a strength rating of "1". You cannot use it because it is too weak and too easy to guess. Please enter a password with a strength rating of "65" or higher.');
+});
+
+test('generatePassword returns a 12 character string', function () {
+    $password = Whm::generatePassword();
+    
+    expect($password)->toBeString()
+        ->toHaveLength(12);
+});

tests/stubs/whm/create_email_already_exists.json

@@ -0,0 +1,5 @@
+{
+    "status": "error",
+    "code": 400,
+    "output": "The account [email protected] already exists!"
+}

tests/stubs/whm/create_email_password_strengh_issue.json

@@ -0,0 +1,5 @@
+{
+    "status": "error",
+    "code": 400,
+    "output": "The password that you entered has a strength rating of “1”. You cannot use it because it is too weak and too easy to guess. Please enter a password with a strength rating of “65” or higher."
+}

tests/stubs/whm/create_email_success.json

@@ -0,0 +1,5 @@
+{
+    "status": "success",
+    "code": 200,
+    "output": "user+example.com"
+}