refactor(ext_hub): Added device speed getter to stop using parent_dev_hdl

Author: roma-jam

host/usb/private_include/ext_hub.h

@@ -82,6 +82,21 @@ void *ext_hub_get_client(void);
 
 // -------------------------- External Hub API ---------------------------------
 
+/**
+ * @brief Get the External Hub device USB speed
+ *
+ * @note Device should be in list of devices
+ *
+ * @param[in]  ext_hub_hdl   External Hub device handle
+ * @param[out] speed         USB speed
+ * @return
+ *    - ESP_ERR_NOT_ALLOWED if the External Hub driver is not installed
+ *    - ESP_ERR_INVALID_ARG if the handle or speed is NULL
+ *    - ESP_ERR_NOT_FOUND if the device is not found
+ *    - ESP_OK if the speed was obtained
+ */
+esp_err_t ext_hub_get_speed(ext_hub_handle_t ext_hub_hdl, usb_speed_t *speed);
+
 /**
  * @brief Add new device
  *

host/usb/src/ext_hub.c

@@ -779,36 +779,27 @@ static void device_free(ext_hub_dev_t *ext_hub_dev)
     heap_caps_free(ext_hub_dev);
 }
 
-static esp_err_t get_dev_by_hdl(usb_device_handle_t dev_hdl, ext_hub_dev_t **ext_hub_hdl)
+static bool dev_is_in_list(ext_hub_dev_t *ext_hub_dev)
 {
-    esp_err_t ret = ESP_OK;
-    // Go through the Hubs lists to find the hub with the specified device address
-    ext_hub_dev_t *found_hub = NULL;
+    bool is_in_list = false;
     ext_hub_dev_t *hub = NULL;
 
     EXT_HUB_ENTER_CRITICAL();
     TAILQ_FOREACH(hub, &p_ext_hub_driver->dynamic.ext_hubs_pending_tailq, dynamic.tailq_entry) {
-        if (hub->constant.dev_hdl == dev_hdl) {
-            found_hub = hub;
+        if (hub == ext_hub_dev) {
+            is_in_list = true;
             goto exit;
         }
     }
-
     TAILQ_FOREACH(hub, &p_ext_hub_driver->dynamic.ext_hubs_tailq, dynamic.tailq_entry) {
-        if (hub->constant.dev_hdl == dev_hdl) {
-            found_hub = hub;
+        if (hub == ext_hub_dev) {
+            is_in_list = true;
             goto exit;
         }
     }
-
 exit:
-    if (found_hub == NULL) {
-        ret = ESP_ERR_NOT_FOUND;
-    }
     EXT_HUB_EXIT_CRITICAL();
-
-    *ext_hub_hdl = found_hub;
-    return ret;
+    return is_in_list;
 }
 
 static esp_err_t get_dev_by_addr(uint8_t dev_addr, ext_hub_dev_t **ext_hub_hdl)
@@ -1294,6 +1285,20 @@ static esp_err_t find_first_intf_desc(const usb_config_desc_t *config_desc, devi
     return (iface_found) ? ESP_OK : ESP_ERR_NOT_FOUND;
 }
 
+esp_err_t ext_hub_get_speed(ext_hub_handle_t ext_hub_hdl, usb_speed_t *speed)
+{
+    EXT_HUB_ENTER_CRITICAL();
+    EXT_HUB_CHECK_FROM_CRIT(p_ext_hub_driver != NULL, ESP_ERR_NOT_ALLOWED);
+    EXT_HUB_EXIT_CRITICAL();
+    EXT_HUB_CHECK(ext_hub_hdl != NULL && speed != NULL, ESP_ERR_INVALID_ARG);
+    EXT_HUB_CHECK(dev_is_in_list(ext_hub_hdl), ESP_ERR_NOT_FOUND);
+    ext_hub_dev_t *ext_hub_dev = (ext_hub_dev_t *)ext_hub_hdl;
+    usb_device_info_t dev_info;
+    ESP_ERROR_CHECK(usbh_dev_get_info(ext_hub_dev->constant.dev_hdl, &dev_info));
+    *speed = dev_info.speed;
+    return ESP_OK;
+}
+
 esp_err_t ext_hub_new_dev(uint8_t dev_addr)
 {
     EXT_HUB_ENTER_CRITICAL();

host/usb/src/hub.c

@@ -352,11 +352,10 @@ static void ext_port_event_callback(ext_port_hdl_t port_hdl, ext_port_event_data
             goto new_ds_dev_err;
         }
 
-        // TODO: IDF-10023 Move responsibility of parent-child tree building to Hub Driver instead of USBH
-        usb_device_info_t parent_dev_info;
-        ESP_ERROR_CHECK(usbh_dev_get_info(event_data->connected.parent_dev_hdl, &parent_dev_info));
-        if (parent_dev_info.speed == USB_SPEED_HIGH) {
-            if (port_speed != parent_dev_info.speed) {
+        usb_speed_t parent_speed;
+        ESP_ERROR_CHECK(ext_hub_get_speed(ext_hub_hdl, &parent_speed));
+        if (parent_speed == USB_SPEED_HIGH) {
+            if (port_speed != parent_speed) {
                 ESP_LOGE(HUB_DRIVER_TAG, "Connected device is %s, transaction translator (TT) is not supported",
                 (char *[]) {
                     "LS", "FS", "HS"