Fix some warnings with ESP-IDF >= 5 (AUD-4923) #1083
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
Fix the following warnings when building with ESP-IDF 5:
In file included from /willow/deps/esp-adf/components/audio_stream/lib/gzip/miniz_inflate.h:32,
from /willow/deps/esp-adf/components/audio_stream/lib/gzip/gzip_miniz.c:30:
/opt/esp/idf/components/esp_rom/include/esp32s3/rom/miniz.h:7:2: warning: #warning "{target}/rom/miniz.h is deprecated, please use (#include "miniz.h") instead" [-Wcpp]
7 | #warning "{target}/rom/miniz.h is deprecated, please use (#include "miniz.h") instead"
| ^~~~~~~
/willow/deps/esp-adf/components/audio_stream/i2s_stream.c:142:5: warning: 'dma_buf_count' is deprecated [-Wdeprecated-declarations]
142 | int index = i2s->config.i2s_config.dma_buf_count;
| ^~~
In file included from /opt/esp/idf/components/driver/deprecated/driver/i2s.h:20,
from /willow/deps/esp-adf/components/audio_stream/i2s_stream.c:33:
/opt/esp/idf/components/driver/deprecated/driver/i2s_types_legacy.h:225:13: note: declared here
225 | int dma_buf_count __attribute__((deprecated)); /*!< This is an alias to 'dma_desc_num' for backward compatibility */
| ^~~~~~~~~~~~~
/willow/deps/esp-adf/components/audio_stream/i2s_stream.c:143:5: warning: 'dma_buf_len' is deprecated [-Wdeprecated-declarations]
143 | uint8_t *buf = audio_calloc(1, i2s->config.i2s_config.dma_buf_len * 4);
| ^~~~~~~
/opt/esp/idf/components/driver/deprecated/driver/i2s_types_legacy.h:229:13: note: declared here
229 | int dma_buf_len __attribute__((deprecated)); /*!< This is an alias to 'dma_frame_num' for backward compatibility */
| ^~~~~~~~~~~
/willow/deps/esp-adf/components/audio_stream/i2s_stream.c:151:9: warning: 'dma_buf_len' is deprecated [-Wdeprecated-declarations]
151 | audio_element_output(self, (char *)buf, i2s->config.i2s_config.dma_buf_len * 4);
| ^~~~~~~~~~~~~~~~~~~~
/opt/esp/idf/components/driver/deprecated/driver/i2s_types_legacy.h:229:13: note: declared here
229 | int dma_buf_len __attribute__((deprecated)); /*!< This is an alias to 'dma_frame_num' for backward compatibility */
| ^~~~~~~~~~~
Signed-off-by: Stijn Tintel <[email protected]>
Fix the following warnings when building with ESP-IDF >= 5.1.
Building C object esp-idf/esp_peripherals/CMakeFiles/__idf_esp_peripherals.dir/lib/sdcard/sdcard.c.obj/willow/deps/esp-adf/components/esp_peripherals/lib/sdcard/sdcard.c: In function 'sdcard_unmount':
/willow/deps/esp-adf/components/esp_peripherals/lib/sdcard/sdcard.c:168:5: warning: 'esp_vfs_fat_sdmmc_unmount' is deprecated: Please use esp_vfs_fat_sdcard_unmount instead [-Wdeprecated-declarations]
168 | esp_err_t ret = esp_vfs_fat_sdmmc_unmount();
| ^~~~~~~~~
In file included from /willow/deps/esp-adf/components/esp_peripherals/lib/sdcard/sdcard.c:32:
/opt/esp/idf/components/fatfs/vfs/esp_vfs_fat.h:197:11: note: declared here
197 | esp_err_t esp_vfs_fat_sdmmc_unmount(void) __attribute__((deprecated("Please use esp_vfs_fat_sdcard_unmount instead")));
| ^~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Stijn Tintel <[email protected]>
stintel
force-pushed
the
fix/idf5_warnings
branch
from
e69f74d to
3b7627e
Compare
Collaborator
|
@stintel Thank you for your contributions. We separate the I2S by different IDF versions. And we are writing a new i2s_stream_v5.x file for IDF v5.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building Willow with ESP-IDF 5.1, a bunch of warnings appear due to GCC 12 being much stricter and ESP-IDF deprecating some code used by ESP-ADF. We've suppressed some of those warnings with the following skdconfig changes:
Afterwards, a few warnings remain. This PR, and espressif/esp-adf-libs#27 fix the remaining warnings we see.