Skip to content

Allow group_leader() to define shell:whereis() #10316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
potatosalad wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow group_leader() to define shell:whereis() #10316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions lib/kernel/src/group.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,13 +174,26 @@ init(internal, [Shell, Options], State = #state{ dumb = Dumb }) ->

-spec whereis_shell() -> undefined | pid().
whereis_shell() ->
case node(group_leader()) of
GroupLeaderPid = group_leader(),
case node(GroupLeaderPid) of
Node when Node =:= node() ->
case user_drv:whereis_group() of
undefined -> undefined;
GroupPid ->
{dictionary, Dict} = erlang:process_info(GroupPid, dictionary),
proplists:get_value(shell, Dict)
Key = {dictionary, shell},
maybe
{Key, GroupLeaderShellPid} ?= erlang:process_info(GroupLeaderPid, Key),
true ?= is_pid(GroupLeaderShellPid),
GroupLeaderShellPid
else
_ ->
maybe
GroupPid ?= user_drv:whereis_group(),
true ?= is_pid(GroupPid),
{Key, GroupShellPid} ?= erlang:process_info(GroupPid, Key),
true ?= is_pid(GroupShellPid),
GroupShellPid
else
_ ->
undefined
end
end;
OtherNode ->
erpc:call(OtherNode, group, whereis_shell, [])
Expand Down
Loading