Skip to content

[BUG] CI binary size check logs oversized binaries but still passes #343

Description

@equationzhao

Describe the bug
The GitHub Actions binary size checks print a warning when the binary exceeds 10 MB, but they do not fail the job. This means the check cannot protect the size budget even when the limit is exceeded.

To Reproduce

  1. Inspect .github/workflows/go.yml.
  2. Find the binary size check steps.
  3. The condition only prints Binary size exceeds 10MB and does not run exit 1.

Screenshots
Not applicable.

Info (please complete the following information):

  • OS: GitHub Actions
  • Version: v0.31.2

Additional context
This is related to binary size governance, but it is separate from feature work to reduce the binary size. The CI check should either fail when the limit is exceeded or be renamed as an informational check.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions