Alice is party 2 in the circuit?

[bl4ck5un]

When using Bristol circuits, Alice's input actually corresponds to the 2nd party while Bob the first. This flip of order is really confusing. If it's intended, it better be clearly stated in the README.

E.g., Here

emp-ag2pc/emp-ag2pc/2pc.h

Lines 320 to 324 in 163985c

	if(party == ALICE) {
	for(int i = cf->n1; i < cf->n1+cf->n2; ++i) {
	mask_input[i] = logic_xor(input[i - cf->n1], value[i]);
	mask_input[i] = logic_xor(mask_input[i], mask[i]);
	}

, Alice reads n2 bits from the input. The tests didn't catch this because they use the same input from both parties.

[wangxiao1254]

This is definitely not intentional :) It is now on the schedule to be fixed.

I just edited that code section into this:

		if(party == ALICE) { 
			for(int i = 0; i < cf->n1; i++) {
				mask_input[i] = logic_xor(input[i], value[exec_times][i]);
				mask_input[i] = logic_xor(mask_input[i], mask[exec_times][i]);
			}
			io->recv_data(mask_input+cf->n1, cf->n2);
			io->send_data(mask_input, cf->n1);
			for(int i = 0; i < cf->n1 + cf->n2; i++) {
				tmp = labels[exec_times][i];
				if(mask_input[i]) tmp = xorBlocks(tmp, fpre->Delta);
				io->send_block(&tmp, 1);
			}
			//send output mask data
			send_partial_block<SSP>(io, mac[exec_times]+cf->num_wire - cf->n3, cf->n3);
		} else { 
			for(int i = cf->n1; i < cf->n1+cf->n2; i++) {
				mask_input[i] = logic_xor(input[i-cf->n1], value[exec_times][i]);
				mask_input[i] = logic_xor(mask_input[i], mask[exec_times][i]);
			}
			io->send_data(mask_input+cf->n1, cf->n2);
			io->recv_data(mask_input, cf->n1);
			io->recv_block(labels[exec_times], cf->n1 + cf->n2);
		}

That reflects my naive understanding of how the code should be at that position. However, the code crashes and/or I get a lot of "no match GT"s.

Any idea?

[wangxiao1254]

Would it work for you to just swap the role of ALICE and BOB?

Yes! It's a brain twist, but I will get used to it. 😄

[wangxiao1254]

We will put a new version with greatly improved performance; this will definitely be fixed by then. Xiao

…

On Thu, Sep 19, 2019 at 11:31 AM GitHubKilla ***@***.***> wrote: Yes! It's a brain twist, but I will get used to it. 😄 — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#8?email_source=notifications&email_token=AARKGCU2KXFXXMQ65RZWXHLQKOSPHA5CNFSM4HR7S6M2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7ECJCI#issuecomment-533210249>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARKGCS7JOXP3RFE3N4VXKTQKOSPHANCNFSM4HR7S6MQ> .

[xfap]

Yes,brain twist. Did it fix?…confusing...

[wangxiao1254]

you might need to keep it twisted for a few more months and we will release a completely new version :)