Move test db pwds to external file/secret

Author: emertechie

.github/workflows/api-build-and-test.yml

@@ -2,6 +2,9 @@ name: API Build & Test
 
 on:
   workflow_call:
+    secrets:
+      MSSQL_SA_PASSWORD:
+        required: true
 
 jobs:
   build-and-test:
@@ -12,11 +15,11 @@ jobs:
         image: mcr.microsoft.com/mssql/server:2025-latest
         env:
           ACCEPT_EULA: Y
-          MSSQL_SA_PASSWORD: 2#r4U@8GO1Kv@xNFi3k
+          MSSQL_SA_PASSWORD: ${{ secrets.MSSQL_SA_PASSWORD }}
         ports:
           - 1433:1433
         options: >-
-          --health-cmd "/opt/mssql-tools18/bin/sqlcmd -S localhost -U sa -P '2#r4U@8GO1Kv@xNFi3k' -C -Q 'SELECT 1' || exit 1"
+          --health-cmd "/opt/mssql-tools18/bin/sqlcmd -S localhost -U sa -P '${{ secrets.MSSQL_SA_PASSWORD }}' -C -Q 'SELECT 1' || exit 1"
           --health-interval 10s
           --health-timeout 5s
           --health-retries 5
@@ -39,7 +42,7 @@ jobs:
       - name: Test
         run: dotnet test ProcureHub.sln --no-build --configuration Release --verbosity normal --logger "trx;LogFileName=ProcureHubTests.trx"  --results-directory ./TestResults
         env:
-          ConnectionStrings__DefaultConnection: "Server=localhost;Database=procurehub_tests;User Id=sa;Password=2#r4U@8GO1Kv@xNFi3k;TrustServerCertificate=true"
+          ConnectionStrings__DefaultConnection: "Server=localhost;Database=procurehub_tests;User Id=sa;Password=${{ secrets.MSSQL_SA_PASSWORD }};TrustServerCertificate=true"
 
       - name: Test Report
         uses: dorny/test-reporter@v2

.github/workflows/api-ci.yml

@@ -22,4 +22,5 @@ on:
 jobs:
   build-and-test:
     uses: ./.github/workflows/api-build-and-test.yml
+    secrets: inherit
 

.github/workflows/api-deploy-staging.yml

@@ -26,6 +26,7 @@ permissions:
 jobs:
   build-and-test:
     uses: ./.github/workflows/api-build-and-test.yml
+    secrets: inherit
 
   push-image:
     needs: build-and-test

.gitignore

@@ -13,6 +13,7 @@ todos.md
 .notes/
 .context/ignore
 .bruno/
+.env
 Prototype/
 
 # Terraform

compose.yaml

@@ -6,7 +6,7 @@ services:
       - "1433:1433"
     environment:
       ACCEPT_EULA: Y
-      MSSQL_SA_PASSWORD: 2#r4U@8GO1Kv@xNFi3k
+      MSSQL_SA_PASSWORD: ${MSSQL_SA_PASSWORD}
     volumes:
       - sqldata:/var/opt/mssql
     restart: unless-stopped