Skip to content

Commit 60d499b

Browse files
authored
Merge pull request #775 from bertdeblock/fix-ci
2 parents b43081b + bbdf833 commit 60d499b

File tree

6 files changed

+964
-287
lines changed

6 files changed

+964
-287
lines changed

.github/workflows/ci.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ jobs:
1616
runs-on: ubuntu-latest
1717

1818
steps:
19-
- uses: actions/checkout@v1
20-
- uses: actions/setup-node@v1
19+
- uses: actions/checkout@v3
20+
- uses: actions/setup-node@v3
2121
with:
2222
node-version: 12.x
2323
- name: install dependencies
@@ -38,8 +38,8 @@ jobs:
3838
node-version: [12.x, 14.x]
3939

4040
steps:
41-
- uses: actions/checkout@v1
42-
- uses: actions/setup-node@v1
41+
- uses: actions/checkout@v3
42+
- uses: actions/setup-node@v3
4343
with:
4444
node-version: ${{ matrix.node-version }}
4545
- name: install dependencies
@@ -56,8 +56,8 @@ jobs:
5656
needs: [test, lint]
5757

5858
steps:
59-
- uses: actions/checkout@v1
60-
- uses: actions/setup-node@v1
59+
- uses: actions/checkout@v3
60+
- uses: actions/setup-node@v3
6161
with:
6262
node-version: 12.x
6363
- name: install dependencies
@@ -93,8 +93,8 @@ jobs:
9393
- with-ember-cli-htmlbars-inline-precompile
9494

9595
steps:
96-
- uses: actions/checkout@v1
97-
- uses: actions/setup-node@v1
96+
- uses: actions/checkout@v3
97+
- uses: actions/setup-node@v3
9898
with:
9999
node-version: 12.x
100100
- name: install dependencies

config/ember-try.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,17 +12,25 @@ module.exports = async function () {
1212
npm: {
1313
devDependencies: {
1414
'ember-source': '~3.8.0',
15+
'ember-styleguide': '^5.0.0',
1516
'ember-cli': '~3.8.0',
1617
},
18+
ember: {
19+
edition: 'classic',
20+
},
1721
},
1822
},
1923
{
2024
name: 'ember-lts-3.12',
2125
npm: {
2226
devDependencies: {
2327
'ember-source': '~3.12.0',
28+
'ember-styleguide': '^5.0.0',
2429
'ember-cli': '~3.12.0',
2530
},
31+
ember: {
32+
edition: 'classic',
33+
},
2634
},
2735
},
2836
{

config/environment.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ module.exports = function (environment) {
55
modulePrefix: 'ember-cli-htmlbars',
66
environment,
77
rootURL: '/',
8-
locationType: 'auto',
8+
locationType: 'history',
99
EmberENV: {
1010
FEATURES: {
1111
// Here you can enable experimental features on an ember canary build

package.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,14 +72,13 @@
7272
"ember-cli-babel": "^7.26.6",
7373
"ember-cli-dependency-checker": "^3.2.0",
7474
"ember-cli-inject-live-reload": "^2.1.0",
75-
"ember-export-application-global": "^2.0.1",
7675
"ember-load-initializers": "^2.1.1",
7776
"ember-maybe-import-regenerator": "^0.1.6",
7877
"ember-qunit": "^5.1.4",
7978
"ember-resolver": "^8.0.2",
8079
"ember-source": "~3.28.0",
8180
"ember-source-channel-url": "^3.0.0",
82-
"ember-styleguide": "^5.0.0",
81+
"ember-styleguide": "^8.4.0",
8382
"ember-template-lint": "^3.6.0",
8483
"ember-try": "^1.4.0",
8584
"eslint": "^7.32.0",
@@ -106,6 +105,9 @@
106105
"publishConfig": {
107106
"registry": "https://registry.npmjs.org"
108107
},
108+
"ember": {
109+
"edition": "octane"
110+
},
109111
"ember-addon": {
110112
"main": "lib/ember-addon-main.js",
111113
"configPath": "tests/dummy/config"

tests/dummy/config/environment.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ module.exports = function (environment) {
55
modulePrefix: 'dummy',
66
environment,
77
rootURL: '/',
8-
locationType: 'auto',
8+
locationType: 'history',
99
EmberENV: {
1010
FEATURES: {
1111
// Here you can enable experimental features on an ember canary build

0 commit comments

Comments
 (0)