Mark candidates in `helm-do-grep-ag` results

[ZedThree]

Suggestion

(Thanks for a fantastic package btw!)

The recently deprecated/removed helm-ag package had the ability to mark candidates and open a buffer to edit the selected candidates. Reading through the issues here and at melpa, it looks like wgrep is the recommended replacement for this functionality -- however, helm-do-grep-ag doesn't allow marking candidates (and this appears to be intentional?).

Description

I'd like to be able to mark candidates in helm-do-grep-ag results, in order to be able to send the selection to wgrep.

Solutions

I'm not sure if it's sufficient to just remove the restriction on marking candidates for helm-do-grep-ag, or if wgrep-helm also needs to be modified to accept the selection, rather than working from the whole list of results

[thierryvolpiatto]

Peter Hill ***@***.***> writes:

● ZedThree created an issue (emacs-helm/helm#2737) Suggestion (Thanks for a fantastic package btw!) The recently deprecated/removed helm-ag package had the ability to mark candidates and open a buffer to edit the selected candidates. Reading through the issues here and at melpa, it looks like wgrep is the recommended replacement for this functionality -- however, helm-do-grep-ag doesn't allow marking candidates (and this appears to be intentional?).

Yes, I wouldn't use this. What I do generally is narrow down as much as possible, if it is not enough, I hit C-c s to narrow down the resulting helm grep buffer (this is matching only what you have in the result buffer, no more grepping something else) and then save. When you use wgrep, that's mean generally you have a lot of candidates to modify and most of the time the pattern you want to modify is what you searched for, marking such an amount of candidates would be a pain, OTOH if you want to modify only few candidates, it's easy to modify them directly from the wgrep buffer (I mean without mass renaming like iedit or qurey-replace).

…

Description I'd like to be able to mark candidates in helm-do-grep-ag results, in order to be able to send the selection to wgrep. Solutions I'm not sure if it's sufficient to just remove the restriction on marking candidates for helm-do-grep-ag, or if wgrep-helm also needs to be modified to accept the selection, rather than working from the whole list of results — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

-- Thierry

[thierryvolpiatto]

Peter Hill ***@***.***> writes:

● ZedThree created an issue (emacs-helm/helm#2737) Solutions I'm not sure if it's sufficient to just remove the restriction on marking candidates for helm-do-grep-ag, or if wgrep-helm also needs to be modified to accept the selection, rather than working from the whole list of results

It is not, in addition here are the things to modify: 1) helm-grep-save-results-1: @@ -899,3 +899,6 @@ - (insert (with-current-buffer helm-buffer - (goto-char (point-min)) (forward-line 1) - (buffer-substring (point) (point-max))))) + (helm-aif (with-helm-buffer helm-marked-candidates) + (cl-loop for (src . cand) in it + do (insert cand "\n")) + (insert (with-current-buffer helm-buffer + (goto-char (point-min)) (forward-line 1) + (buffer-substring (point) (point-max)))))) 2) Use marked-with-props in both helm-grep-ag-class and helm-grep-ag-search-results. 3) helm grep-ag has a revert-buffer function, I am not sure it makes sense to modify it to handle only the marked candidates. 4) next-error should apply only on these marked candidates? I am not sure either if it makes sense. So if this would be introduced, 3) and 4) should not be implemented, leaving the opportunity to the user to press "g" and use next-error on the whole set of matches, however it would be confusing, so I don't know yet what would be the best design for this.

…

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

-- Thierry