Fix problem that isWebkit be true on Chrome
#629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user agent on Chrome also contains `AppleWebKit`。 Therefore the origin judgement condition will treat Chrome as "WebKit inside a native macOS app". Here is the user agent string of Chrome 80 for Windows 10: ``` Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.106 Safari/537.36 ```
|
It's true on almost all platforms except of Firefox on Linux: https://deviceatlas.com/blog/list-of-user-agent-strings |
Contributor
|
Yikes, you're right. That was my fault, I'm not sure how I missed that. I'll look into another way to detect webviews inside native macOS apps 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user agent on Chrome also contains
AppleWebKit。 Therefore the origin judgement condition will treat Chrome as "WebKit inside a native macOS app".Here is the user agent string of Chrome 80 for Windows 10: