Add validators for package and datastream names (#1433)

Add validators when creating a new package or a new data stream
to check whether or not the package name or data stream have valid
values according to the spec.

Author: mrodm

cmd/create_data_stream.go

@@ -56,7 +56,7 @@ func createDataStreamCommandAction(cmd *cobra.Command, args []string) error {
 				Message: "Data stream name:",
 				Default: "new_data_stream",
 			},
-			Validate: survey.ComposeValidators(survey.Required, surveyext.DataStreamDoesNotExistValidator),
+			Validate: survey.ComposeValidators(survey.Required, surveyext.DataStreamDoesNotExistValidator, surveyext.DataStreamNameValidator),
 		},
 		{
 			Name: "title",

cmd/create_package.go

@@ -67,7 +67,7 @@ func createPackageCommandAction(cmd *cobra.Command, args []string) error {
 				Message: "Package name:",
 				Default: "new_package",
 			},
-			Validate: survey.ComposeValidators(survey.Required, surveyext.PackageDoesNotExistValidator),
+			Validate: survey.ComposeValidators(survey.Required, surveyext.PackageDoesNotExistValidator, surveyext.PackageNameValidator),
 		},
 		{
 			Name: "version",

internal/surveyext/validators.go

@@ -16,6 +16,9 @@ import (
 
 var (
 	githubOwnerRegexp = regexp.MustCompile(`^(([a-zA-Z0-9-]+)|([a-zA-Z0-9-]+\/[a-zA-Z0-9-]+))$`)
+
+	packageNameRegexp    = regexp.MustCompile(`^[a-z0-9_]+$`)
+	dataStreamNameRegexp = regexp.MustCompile(`^([a-z0-9]{2}|[a-z0-9][a-z0-9_]+[a-z0-9])$`)
 )
 
 // PackageDoesNotExistValidator function checks if the package hasn't been already created.
@@ -84,3 +87,27 @@ func GithubOwnerValidator(val interface{}) error {
 	}
 	return nil
 }
+
+func PackageNameValidator(val interface{}) error {
+	packageName, ok := val.(string)
+	if !ok {
+		return errors.New("string type expected")
+	}
+
+	if !packageNameRegexp.MatchString(packageName) {
+		return fmt.Errorf("value doesn't match the regular expression (package name): %s", packageNameRegexp.String())
+	}
+	return nil
+}
+
+func DataStreamNameValidator(val interface{}) error {
+	dataStreamFolderName, ok := val.(string)
+	if !ok {
+		return errors.New("string type expected")
+	}
+
+	if !dataStreamNameRegexp.MatchString(dataStreamFolderName) {
+		return fmt.Errorf("value doesn't match the regular expression (datastream name): %s", dataStreamNameRegexp.String())
+	}
+	return nil
+}