Update GeoLite Database #46
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the GeoLite database workflow to target a different release branch and modernizes several aspects of the automated PR creation process. The changes shift from targeting the "master" branch to "release-ulmo" and update authentication, reviewers, and branch naming conventions.
Key Changes
- Updates default target branch from "master" to "release-ulmo" for both workflow input and PR creation
- Modernizes branch naming to use
github.run_idinstead of truncatedgithub.shafor better uniqueness - Switches authentication from
github.tokentosecrets.GH_PAT_WITH_ORG(likely needed for organization-level permissions)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| --base 'master' \ | ||
| --reviewer 'feanil' \ | ||
| --head "$BRANCH" \ | ||
| --base 'release-ulmo' \ |
There was a problem hiding this comment.
The --base flag is hardcoded to 'release-ulmo' but should use the workflow input parameter ${{ inputs.branch }} instead. This makes the branch input parameter (lines 8-11) non-functional.
Change to:
--base '${{ inputs.branch }}' \
Suggested change
| --base 'release-ulmo' \ | |
| --base '${{ inputs.branch }}' \ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR generated by workflow on behalf of @ktyagiapphelix2u.