to stabilize TestConnectorsResultImportUrls, catch StaleElementReferenceException;

when this exception is thrown, catch it and return null for the table
entry looked for; this is intended to cause the waitUntil method to try
again instead of failing with the exception

Author: axeluhl

java/com.sap.sailing.selenium.test/src/com/sap/sailing/selenium/pages/adminconsole/connectors/ResultImportUrlsPanelPO.java

@@ -2,6 +2,8 @@
 
 import static org.junit.jupiter.api.Assertions.assertNotNull;
 
+import java.util.logging.Logger;
+
 import org.openqa.selenium.StaleElementReferenceException;
 import org.openqa.selenium.WebDriver;
 import org.openqa.selenium.WebElement;
@@ -16,6 +18,7 @@
 import com.sap.sailing.selenium.pages.gwt.ListBoxPO;
 
 public class ResultImportUrlsPanelPO extends PageArea {
+    private static final Logger logger = Logger.getLogger(ResultImportUrlsPanelPO.class.getName());
 
     @FindBy(how = BySeleniumId.class, using = "urlProviderListBox")
     private WebElement urlProviderListBox;
@@ -71,23 +74,27 @@ public void removeWithInlineButton(String url) {
         waitUntil(() -> findUrl(url) == null);
     }
 
-    private CellTablePO<DataEntryPO> getUserTable() {
+    private CellTablePO<DataEntryPO> getUrlTable() {
         return new GenericCellTablePO<>(this.driver, this.urlTable, DataEntryPO.class);
     }
 
     public DataEntryPO findUrl(final String url) {
-        final CellTablePO<DataEntryPO> table = getUserTable();
-        for (DataEntryPO entry : table.getEntries()) {
-            String name;
-            try {
-                name = entry.getColumnContent("URL");
-            } catch (StaleElementReferenceException e) {
-                // entry is not existing any more but must not break iteration
-                name = null;
-            }
-            if (url.equals(name)) {
-                return entry;
+        try {
+            final CellTablePO<DataEntryPO> table = getUrlTable();
+            for (DataEntryPO entry : table.getEntries()) {
+                String name;
+                try {
+                    name = entry.getColumnContent("URL");
+                } catch (StaleElementReferenceException e) {
+                    // entry is not existing any more but must not break iteration
+                    name = null;
+                }
+                if (url.equals(name)) {
+                    return entry;
+                }
             }
+        } catch (StaleElementReferenceException e) {
+            logger.warning("Stale element when trying to find URL in result import source table: "+e.getMessage());
         }
         return null;
     }

java/com.sap.sailing.selenium.test/src/com/sap/sailing/selenium/test/adminconsole/TestConnectorsResultImportUrls.java

@@ -40,7 +40,6 @@ public void testUrlInlineDeletion() throws InterruptedException {
         resultImportUrlsPanel.selectUrlProviderByLabel(TEST_URL_PROVIDER_LABEL);
         // add
         resultImportUrlsPanel.addUrl(TEST_URL);
-        Thread.sleep(1000); // give event loop time to render table
         resultImportUrlsPanel.removeWithInlineButton(TEST_URL);
     }
 }