new flag for propagating auto scale disablement #2748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arunjose696
changed the title
akoch-yatta
reviewed
Nov 11, 2025
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Control.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Control.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/widgets/Control.java
Show resolved
Hide resolved
Previously, if a control had AutoScaleDisabled, all its children would inherit this setting by default.
This commit introduces a new flag PROPAGATE_AUTOSCALE_DISABLED (default: true). Setting it to false via control.setData("PROPAGATE_AUTOSCALE_DISABLED", false) prevents children from inheriting AutoScaleDisabled.
This fixes issues with cell editors in GEF-classic
arunjose696
force-pushed
the
arunjose696/494/InheritAutoScaleDisablement
branch
from
4c67a74 to
d1dac03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a control had AutoScaleDisabled, all its children would inherit this setting by default. This change introduces a new flag PROPAGATE_AUTOSCALE_DISABLED (default: true). Setting it to false via ontrol.setData("PROPAGATE_AUTOSCALE_DISABLED", false) prevents children from inheriting AutoScaleDisabled.
The fix is based on @amartya4256 branch
This change fixes issues with cell editors in GEF-classic.
Steps to reproduce
Follow steps in eclipse-gef/gef-classic#850